From: Eric Sandeen <sandeen@sandeen.net>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] XFS: Replace deprecated "TOPDIR" with newer "src"
Date: Tue, 20 Nov 2007 08:51:42 -0600 [thread overview]
Message-ID: <4742F47E.9090909@sandeen.net> (raw)
In-Reply-To: <alpine.LFD.0.9999.0711200431590.21514@localhost.localdomain>
Robert P. J. Day wrote:
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---
>
> given that TOPDIR is explicitly deprecated in favour of src, this
> would seem to be an obvious change.
>
>
> diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile
> index 49e3e7e..e1b08b7 100644
> --- a/fs/xfs/Makefile
> +++ b/fs/xfs/Makefile
> @@ -1 +1 @@
> -include $(TOPDIR)/fs/xfs/Makefile-linux-$(VERSION).$(PATCHLEVEL)
> +include $(src)/fs/xfs/Makefile-linux-$(VERSION).$(PATCHLEVEL)
There are already a couple changes in cvs which obsolete this:
http://oss.sgi.com/archives/xfs/2007-07/msg00295.html
and
http://oss.sgi.com/archives/xfs/2007-09/msg00361.html
Thanks,
-Eric
prev parent reply other threads:[~2007-11-20 14:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-20 9:33 [PATCH] XFS: Replace deprecated "TOPDIR" with newer "src" Robert P. J. Day
2007-11-20 14:51 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4742F47E.9090909@sandeen.net \
--to=sandeen@sandeen.net \
--cc=rpjday@crashcourse.ca \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox