Re: [PATCH 2/2] Debug - don't exhaustively check the AIL on every operation

David Chinner
2007-11-23T01:24:36Z

On Fri, Nov 23, 2007 at 11:43:14AM +1100, Lachlan McIlroy wrote:
> Looks good Dave.
>
> There's lots of debug code bound by XFS_TRANS_DEBUG - should we be
> enabling this in our QA?

No, they are more for validation when you are hacking on the
transaction code. The current debug code should detect most
problems runtime problems, but if you change the way anything in the
logging works you'll be wanting to test your changes with that set
(e.g. when we do the transaction rollback stuff).

Cheers,

Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group