Re: [review] Remove the xfs refcache

Greg Banks
2007-12-17T07:25:17Z

On Mon, Dec 17, 2007 at 07:14:27AM +0000, Christoph Hellwig wrote:
> On Mon, Dec 17, 2007 at 03:00:04PM +1100, Lachlan McIlroy wrote:
> > Hey hold on there buddy! We may need to reactivate this code to fix some
> > performance issues. I've acttually got this code working and proven that
> > it is one way to fix some of the NAS/NFS issues we have.
> >
> > The little comment that reads "reference cache not needed for NFS in 2.6"
> > is wrong - we do need it or something like it.
>
> Not in XFS, though. This thing needs to be done genericly in NFSD.
> Greg has been working on an open files cache in nfsd which should be
> helping this.

BTW, status on that: The current implementation has mutated into
a filehandle-to-dentry mapping cache, because that helps some
metadata-heavy workloads too. I've been testing it these last few
weeks at a customer site, and it's been useful, but there are still
some issues to be worked out before I can post it.

> Adding a cache like this back into XFS will get my veto (at least for
> mainline where I have a bit of a say :))

Greg.
--
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
Apparently, I'm Bedevere. Which MPHG character are you?
I don't speak for SGI.