Re: [REVIEW] Refactor xfs_repair's process_dinode_int

[Timothy Shimmin <tes@sgi.com>]

Not that it is a big deal....but my 2 cents...

Barry Naujok wrote:
> On Wed, 16 Jan 2008 07:33:29 +1100, Chandan Talukdar <chandan@agami.com> 
> wrote:
> 
>> Hi Barry,
>>
>> - In process_misc_ino_types(), dino->di_core.di_size is being accessed 
>> without being converted to machine format.  The check is being 
>> performed against 0; so, it should be fine.  But for better code 
>> readability, I guess it should be accessed through be64_to_cpu().
> 
> Yeah... sort of in two-minds about this one.
> 
Well, traditionally we would not be endian converting it.
We don't endian convert things which are compared to zero or
are only 1 byte. There are a bunch of examples in the kernel
code (many Christoph has done) and we should be consistent IMHO.

(There is, of course, no point from a code point of view -
I guess you might consider that you are letting people know
that we need to endian convert this value in general and
that if we change the code in the future it might be needed...
but just say no.:)

--Tim