Re: [REVIEW 2/2] Case insensitive support for XFS - user-space

[Eric Sandeen <sandeen@sandeen.net>]

Eric Sandeen wrote:

> Also, if I specify -nutf8=default on a 500m fs:
> 
> # mkfs.xfs -dfile,name=fsfile,size=500m -nutf8=default
> meta-data=fsfile                 isize=256    agcount=4, agsize=32000 blks
>          =                       sectsz=512   attr=2
> data     =                       bsize=4096   blocks=128000, imaxpct=25
>          =                       sunit=0      swidth=0 blks
> naming   =version 2              bsize=4096   utf8=default
> log      =internal log           bsize=4096   blocks=1200, version=2
>          =                       sectsz=512   sunit=0 blks, lazy-count=0
> realtime =none                   extsz=4096   blocks=0, rtextents=0
> mkfs.xfs: cannot reserve space: No space left on device

        /*
         * allocate the inode
         */
        tp = libxfs_trans_alloc(mp, 0);
        error =  libxfs_trans_reserve(tp, XFS_CREATE_LOG_RES(mp), 0, 0,
0, 0);
        if (error) {
                fprintf(stderr, _("%s: 1: cannot reserve space: %s (%d)\n"),
                        progname, strerror(error), XFS_CREATE_LOG_RES(mp));
                exit(1);
        }


I think there are some wrong arguments to that trans_reserve... at least
XFS_CREATE_LOG_RES should be 3rd arg, no?

-Eric