From: Eric Sandeen <sandeen@sandeen.net>
To: xfs-oss <xfs@oss.sgi.com>, Niv Sardi <xaiki@sgi.com>
Subject: small problem w/ new xfs defaults patch
Date: Sun, 20 Jan 2008 21:46:39 -0600 [thread overview]
Message-ID: <4794159F.9070505@sandeen.net> (raw)
Index: xfsprogs-2.9.4/growfs/xfs_growfs.c
===================================================================
--- xfsprogs-2.9.4.orig/growfs/xfs_growfs.c
+++ xfsprogs-2.9.4/growfs/xfs_growfs.c
@@ -58,7 +58,6 @@ report_info(
int isint,
char *logname,
char *rtname,
- int unwritten,
int lazycount,
int dirversion,
int logversion,
@@ -68,7 +67,7 @@ report_info(
"meta-data=%-22s isize=%-6u agcount=%u, agsize=%u blks\n"
" =%-22s sectsz=%-5u attr=%u\n"
"data =%-22s bsize=%-6u blocks=%llu, imaxpct=%u\n"
- " =%-22s sunit=%-6u swidth=%u blks, unwritten=%u\n"
+ " =%-22s sunit=%-6u swidth=%u blks"
"naming =version %-14u bsize=%-6u\n"
"log =%-22s bsize=%-6u blocks=%u, version=%u\n"
" =%-22s sectsz=%-5u sunit=%u blks, lazy-count=%u\n"
couple things... you lost a "\n" off the end of the data section there...
Also, do you really want to drop reporting of unwritten extents? Even
if you're disallowing the selection on new mkfs's there may still be
different flavors of filesystems in existence, should it still be reported?
-Eric
next reply other threads:[~2008-01-21 3:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-21 3:46 Eric Sandeen [this message]
2008-01-21 5:13 ` small problem w/ new xfs defaults patch Niv Sardi
2008-01-21 5:29 ` Eric Sandeen
2008-01-22 2:28 ` Timothy Shimmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4794159F.9070505@sandeen.net \
--to=sandeen@sandeen.net \
--cc=xaiki@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox