From: Timothy Shimmin <tes@sgi.com>
To: David Chinner <dgc@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [patch] Prevent AIL lock contention during transaction completion
Date: Fri, 15 Feb 2008 10:52:52 +1100 [thread overview]
Message-ID: <47B4D454.4010600@sgi.com> (raw)
In-Reply-To: <20080214234559.GO155259@sgi.com>
David Chinner wrote:
> On Fri, Jan 25, 2008 at 06:42:35PM +1100, David Chinner wrote:
>> On Fri, Jan 25, 2008 at 05:51:33PM +1100, Timothy Shimmin wrote:
>>> So do we really need to call xlog_assign_tail_lsn() then?
>>> Or are we just being conservative in case we missed something?
>> Conservative - the last thing I want is to introduce a subtle
>> difference to the tail lsn in the log record because we didn't
>> update it immediately before writing it to disk. I think we are
>> probably safe removing it, but lets leave that until we got some
>> wider test coverage on this change first....
>
> Tim - did you finish the review of this? Testing on the 2048p
> machine appears to have been successful, so I'm just waiting
> on review ACKs now....
>
> Cheers,
>
> Dave.
Yep, that was an ACK.
--Tim
prev parent reply other threads:[~2008-02-14 23:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-21 5:23 [patch] Prevent AIL lock contention during transaction completion David Chinner
2008-01-23 7:12 ` Timothy Shimmin
2008-01-23 7:34 ` David Chinner
2008-01-25 6:51 ` Timothy Shimmin
2008-01-25 7:42 ` David Chinner
2008-02-14 23:45 ` David Chinner
2008-02-14 23:52 ` Timothy Shimmin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B4D454.4010600@sgi.com \
--to=tes@sgi.com \
--cc=dgc@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox