From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>, xfs@oss.sgi.com
Subject: Re: [PATCH 1/1] XFS: replace *_IDELETE with *_IKEEP
Date: Fri, 15 Feb 2008 10:23:43 -0600 [thread overview]
Message-ID: <47B5BC8F.2090102@sandeen.net> (raw)
In-Reply-To: <20080215161902.GA32398@infradead.org>
Christoph Hellwig wrote:
> On Thu, Feb 14, 2008 at 02:45:39AM -0500, Josef 'Jeff' Sipek wrote:
>> Change the *_IDELETE flags to *_IKEEP, and flip the logic as necessary.
>>
>> This completely eliminates the no-no-no-idelete madness.
>>
>> Additionally, "ikeep" or "noikeep" is always displayed in /proc/mounts
>> option string. This should help clear up any confusion about what the
>> current mode is.
>
> Looks fine to me, and I think the changed display in /proc/<pid>/mounts
> is fine aswell.
>
IMHO if we want to display defaults, then we should probably change it
so that all defaults are displayed, and not make noikeep special in this
respect. (oh, and "noquota" is already there, too)
Doesn't matter much to me either way but it should be consistent across
all options, I think.
-Eric
next prev parent reply other threads:[~2008-02-15 16:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-14 3:34 [PATCH] fix mount option pasing to make inode cluster deletion default (again) Eric Sandeen
2008-02-14 7:45 ` [PATCH 1/1] XFS: replace *_IDELETE with *_IKEEP Josef 'Jeff' Sipek
2008-02-15 16:19 ` Christoph Hellwig
2008-02-15 16:23 ` Eric Sandeen [this message]
2008-02-16 13:22 ` Christoph Hellwig
2008-02-17 21:30 ` Josef 'Jeff' Sipek
2008-02-18 5:33 ` Barry Naujok
2008-02-18 6:26 ` Josef 'Jeff' Sipek
2008-02-18 14:38 ` [PATCH] fix mount option pasing to make inode cluster deletion default (again) Eric Sandeen
2008-02-20 23:39 ` Josef 'Jeff' Sipek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B5BC8F.2090102@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=jeffpc@josefsipek.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox