public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Jan Derfinak <ja@mail.upjs.sk>
Cc: xfs@oss.sgi.com
Subject: Re: Differences in mkfs.xfs and xfs_info output.
Date: Fri, 15 Feb 2008 22:33:32 -0600	[thread overview]
Message-ID: <47B6679C.2040109@sandeen.net> (raw)
In-Reply-To: <47B66223.4080604@sandeen.net>

Eric Sandeen wrote:

> Jan Derfinak wrote:
>   
>> features2 = 0
>>     
>
>
> Looks like neither XFS_SB_VERSION2_ATTR2BIT nor
> XFS_SB_VERSION2_LAZYSBCOUNTBIT is in fact set.
>
> You're on x86_64 aren't you...
>
> This reminds me of an email I sent in 2006....
>   
Does this make it happier for you?  Hmm actually the kernel needs
the analogous change too.  And then probably something to fix up 
all the misformatted filesystems out there.... yuck.

Hmm and I don't know how lazy-sb-count is getting lost, yet :)

Index: xfsprogs/include/xfs_sb.h
===================================================================
--- xfsprogs.orig/include/xfs_sb.h
+++ xfsprogs/include/xfs_sb.h
@@ -151,6 +151,7 @@ typedef struct xfs_sb
 	__uint16_t	sb_logsectsize;	/* sector size for the log, bytes */
 	__uint32_t	sb_logsunit;	/* stripe unit size for the log */
 	__uint32_t	sb_features2;	/* additional feature bits */
+	__uint32_t	sb_dummy;	/* explicit padding */
 } xfs_sb_t;
 
 /*
@@ -169,7 +170,7 @@ typedef enum {
 	XFS_SBS_GQUOTINO, XFS_SBS_QFLAGS, XFS_SBS_FLAGS, XFS_SBS_SHARED_VN,
 	XFS_SBS_INOALIGNMT, XFS_SBS_UNIT, XFS_SBS_WIDTH, XFS_SBS_DIRBLKLOG,
 	XFS_SBS_LOGSECTLOG, XFS_SBS_LOGSECTSIZE, XFS_SBS_LOGSUNIT,
-	XFS_SBS_FEATURES2,
+	XFS_SBS_FEATURES2, XFS_SBS_DUMMY,
 	XFS_SBS_FIELDCOUNT
 } xfs_sb_field_t;
 
Index: xfsprogs/libxfs/xfs_mount.c
===================================================================
--- xfsprogs.orig/libxfs/xfs_mount.c
+++ xfsprogs/libxfs/xfs_mount.c
@@ -140,6 +140,7 @@ static struct {
     { offsetof(xfs_sb_t, sb_logsectsize),0 },
     { offsetof(xfs_sb_t, sb_logsunit),	 0 },
     { offsetof(xfs_sb_t, sb_features2),	 0 },
+    { offsetof(xfs_sb_t, sb_dummy),	 0 },
     { sizeof(xfs_sb_t),			 0 }
 };
 

  reply	other threads:[~2008-02-16  4:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-16  1:34 Differences in mkfs.xfs and xfs_info output Jan Derfinak
2008-02-16  4:10 ` Eric Sandeen
2008-02-16  4:33   ` Eric Sandeen [this message]
2008-02-16  4:36     ` Eric Sandeen
2008-02-16  4:41 ` Eric Sandeen
2008-02-16  7:40 ` David Chinner
2008-02-16 21:49   ` Jan Derfinak
2008-02-16 22:41   ` Jan Derfinak
2008-02-17 13:41     ` Jan Derfinak
2008-02-17 23:06     ` David Chinner
2008-02-18  0:12       ` Jan Derfinak
2008-02-19  0:04         ` Jan Derfinak
2008-02-19  0:20           ` David Chinner
2008-02-19  1:20             ` Jan Derfinak
2008-02-19  1:46               ` David Chinner
2008-02-19  2:10                 ` Jan Derfinak
2008-02-19 14:05                 ` Jan Derfinak
2008-02-20  5:42                   ` David Chinner
2008-03-16 22:44                     ` Jan Derfinak
2008-02-18  0:17       ` Jan Derfinak
2008-02-18  2:07         ` David Chinner
2008-02-18  6:56           ` ja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47B6679C.2040109@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=ja@mail.upjs.sk \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox