From: Eric Sandeen <sandeen@sandeen.net>
To: Barry Naujok <bnaujok@sgi.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [REVIEW] Fix end of device zeroing with > 1K sector sizes
Date: Thu, 21 Feb 2008 22:13:34 -0600 [thread overview]
Message-ID: <47BE4BEE.4050907@sandeen.net> (raw)
In-Reply-To: <op.t6wqj6zq3jf8g2@pc-bnaujok.melbourne.sgi.com>
Barry Naujok wrote:
> It has been found that mkfs with big sector sizes and devices/partitions
> that aren't aligned to the sector size can cause short writes when zeroing
> the end of the device. As mkfs.xfs didn't complete, the filesystem is
> unmountable.
>
> Eg:
>
> # mkfs.xfs -f -L fs_1 -s size=4096 -l size=64m,sunit=512 /dev/hdd1
> mkfs.xfs: error - wrote only 130048 of 131072 bytes
>
>
> The attached patch rounds down the device size to either 1K or
> the sector size, whichever is greater.
Hopefully to a multiple thereof ;)
Looks good to me... and strangely familiar!
-Eric
> Barry.
>
prev parent reply other threads:[~2008-02-22 4:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-22 3:56 [REVIEW] Fix end of device zeroing with > 1K sector sizes Barry Naujok
2008-02-22 4:13 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BE4BEE.4050907@sandeen.net \
--to=sandeen@sandeen.net \
--cc=bnaujok@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox