From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: with ECARTIS (v1.0.0; list xfs); Thu, 21 Feb 2008 21:38:53 -0800 (PST) Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with SMTP id m1M5cZVt017680 for ; Thu, 21 Feb 2008 21:38:46 -0800 Message-ID: <47BE6122.5040007@sgi.com> Date: Fri, 22 Feb 2008 16:44:02 +1100 From: Lachlan McIlroy Reply-To: lachlan@sgi.com MIME-Version: 1.0 Subject: Re: [RFC, patch 1/2] Allow up to 1GB logs in mkfs.xfs References: <20080221230833.GG155407@sgi.com> <20080222050301.GP155407@sgi.com> In-Reply-To: <20080222050301.GP155407@sgi.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com List-Id: xfs To: David Chinner Cc: Niv Sardi , xfs-dev , xfs-oss David Chinner wrote: > On Fri, Feb 22, 2008 at 01:44:38PM +1100, Niv Sardi wrote: >> David Chinner writes: >>> Increase the maximum log size supported by mkfs. > .... >>> Hence logs larger than 2^30 will not work without kernel >>> modifications. Therefore this change is limited to increasing the >>> log size to what we can currently support in kernel space with >>> needing kernel modifications. >> I'm glad you got time to get around this, I didn't include it in the >> first batch as I was told it 'broke things'. > > Right. There's all sorts of nasties lurking if we go over 1GB in > size, but AFAICT up to 1GB is OK. There's still lots of validation > needing to be done - that's why this is an "RFC" and not something > ready for checkin yet. That's where more eye's and testers are > handy... > Dave, have you run any tests to see if we get any speed-ups with this change?