public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Barry Naujok <bnaujok@sgi.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [REVIEW] Add lazy-counter conversion to xfs_repair
Date: Fri, 22 Feb 2008 11:37:29 -0600	[thread overview]
Message-ID: <47BF0859.6020707@sandeen.net> (raw)
In-Reply-To: <op.t6wyesz53jf8g2@pc-bnaujok.melbourne.sgi.com>

Barry Naujok wrote:
> In response to the thread "Differences in mkfs.xfs and xfs_info output.",  
> xfs_repair has been improved to allow version changes/conversion of  
> filesystems.
> 
> So, this patch introduces the first in an ongoing series of in-place  
> filesystem version changes with xfs_repair and the "-c" (convert) option.
> 
> To turn on/off the lazy-superblock feature, run the following xfs_repair  
> commmand on your filesystem:
> 
> # xfs_repair -c lazycount=[0|1] <device>

How about adding this to xfs_admin as well, since some flag changes are
already in there?

i.e. xfs_admin -<something... l and L are taken> could invoke xfs_repair
-c lazycount ...?

It just strikes me as a tad confusing that to change v2 logs or
unwritten extent support, you use xfs_admin, and to change lazy sb
counters, you must run repair...

(I understand that repair must be run post-change, but a common tool to
invoke all feature changes seems good to me)

-Eric

  reply	other threads:[~2008-02-22 18:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-22  6:45 [REVIEW] Add lazy-counter conversion to xfs_repair Barry Naujok
2008-02-22 17:37 ` Eric Sandeen [this message]
2008-02-23  5:06   ` David Chinner
2008-02-24 23:55   ` Barry Naujok
2008-02-25  0:05   ` Barry Naujok

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47BF0859.6020707@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=bnaujok@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox