* [PATCH] remove superflous xfs_readsb call in xfs_mountfs
@ 2007-12-18 17:48 Christoph Hellwig
2008-02-22 3:48 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2007-12-18 17:48 UTC (permalink / raw)
To: xfs
When xfs_mountfs is called by xfs_mount xfs_readsb was called 35 lines
above unconditionally, so there is no need to try to read the superblock
if it's not present. If any other port doesn't have the superblock
read at this point it should just call it directly from it's xfs_mount
equivalent.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6-xfs/fs/xfs/xfs_mount.c
===================================================================
--- linux-2.6-xfs.orig/fs/xfs/xfs_mount.c 2007-12-17 14:34:57.000000000 +0100
+++ linux-2.6-xfs/fs/xfs/xfs_mount.c 2007-12-17 14:35:17.000000000 +0100
@@ -968,11 +968,6 @@ xfs_mountfs(
int uuid_mounted = 0;
int error = 0;
- if (mp->m_sb_bp == NULL) {
- error = xfs_readsb(mp, mfsi_flags);
- if (error)
- return error;
- }
xfs_mount_common(mp, sbp);
/*
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] remove superflous xfs_readsb call in xfs_mountfs
2007-12-18 17:48 [PATCH] remove superflous xfs_readsb call in xfs_mountfs Christoph Hellwig
@ 2008-02-22 3:48 ` Christoph Hellwig
2008-03-03 0:32 ` Donald Douwsma
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2008-02-22 3:48 UTC (permalink / raw)
To: xfs
On Tue, Dec 18, 2007 at 06:48:29PM +0100, Christoph Hellwig wrote:
> When xfs_mountfs is called by xfs_mount xfs_readsb was called 35 lines
> above unconditionally, so there is no need to try to read the superblock
> if it's not present. If any other port doesn't have the superblock
> read at this point it should just call it directly from it's xfs_mount
> equivalent.
Ping?
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: linux-2.6-xfs/fs/xfs/xfs_mount.c
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/xfs_mount.c 2007-12-17 14:34:57.000000000 +0100
> +++ linux-2.6-xfs/fs/xfs/xfs_mount.c 2007-12-17 14:35:17.000000000 +0100
> @@ -968,11 +968,6 @@ xfs_mountfs(
> int uuid_mounted = 0;
> int error = 0;
>
> - if (mp->m_sb_bp == NULL) {
> - error = xfs_readsb(mp, mfsi_flags);
> - if (error)
> - return error;
> - }
> xfs_mount_common(mp, sbp);
>
> /*
---end quoted text---
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] remove superflous xfs_readsb call in xfs_mountfs
2008-02-22 3:48 ` Christoph Hellwig
@ 2008-03-03 0:32 ` Donald Douwsma
0 siblings, 0 replies; 3+ messages in thread
From: Donald Douwsma @ 2008-03-03 0:32 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
Christoph Hellwig wrote:
> On Tue, Dec 18, 2007 at 06:48:29PM +0100, Christoph Hellwig wrote:
>> When xfs_mountfs is called by xfs_mount xfs_readsb was called 35 lines
>> above unconditionally, so there is no need to try to read the superblock
>> if it's not present. If any other port doesn't have the superblock
>> read at this point it should just call it directly from it's xfs_mount
>> equivalent.
>
> Ping?
Looks good, will be in shortly.
Don
>
>>
>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>>
>> Index: linux-2.6-xfs/fs/xfs/xfs_mount.c
>> ===================================================================
>> --- linux-2.6-xfs.orig/fs/xfs/xfs_mount.c 2007-12-17 14:34:57.000000000 +0100
>> +++ linux-2.6-xfs/fs/xfs/xfs_mount.c 2007-12-17 14:35:17.000000000 +0100
>> @@ -968,11 +968,6 @@ xfs_mountfs(
>> int uuid_mounted = 0;
>> int error = 0;
>>
>> - if (mp->m_sb_bp == NULL) {
>> - error = xfs_readsb(mp, mfsi_flags);
>> - if (error)
>> - return error;
>> - }
>> xfs_mount_common(mp, sbp);
>>
>> /*
> ---end quoted text---
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-03-03 0:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-18 17:48 [PATCH] remove superflous xfs_readsb call in xfs_mountfs Christoph Hellwig
2008-02-22 3:48 ` Christoph Hellwig
2008-03-03 0:32 ` Donald Douwsma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox