public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Kevin Xu <cgxu.gg@gmail.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfscn@googlegroups.com, xfs@oss.sgi.com
Subject: Re: [PATCH]fix the algorithm for addname in xfs_da_node_lookup_int
Date: Sun, 23 Mar 2008 11:05:51 +0800	[thread overview]
Message-ID: <47E5C90F.70303@gmail.com> (raw)
In-Reply-To: <47E5B64E.5090504@sandeen.net>

Eric Sandeen wrote:
> Kevin Xu wrote:
>   
>> fix the algorithm for addname in xfs_da_node_lookup_int
>>     
>
> Could you please include a bit more of a changelog, i.e. what was broken
> and how does this fix it?  Perhaps a testcase, if there is one?
>
> -Eric
>
>   
I think there is a problem in original processing.
When add a new entry and its hash value is already exist in current 
directory, furthermore the hash value
is the last one in a leaf block, although we already found a freespace 
block for adding the new entry,
but we drop this one and continue to check, until the last same hash value.
I think the reason is that xfs_da_node_lookup_int is a common function 
for addname and lookup.


I added a condition before enter another leaf block, only when we didn't 
find a freespace block for the new entry,
then we need to enter another leaf block.

Regards
Kevin

  reply	other threads:[~2008-03-23  3:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-23  1:03 [PATCH]fix the algorithm for addname in xfs_da_node_lookup_int Kevin Xu
2008-03-23  1:45 ` Eric Sandeen
2008-03-23  3:05   ` Kevin Xu [this message]
2008-03-24 22:47 ` David Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47E5C90F.70303@gmail.com \
    --to=cgxu.gg@gmail.com \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    --cc=xfscn@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox