From: Eric Sandeen <sandeen@sandeen.net>
To: xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH] xfsqa: call _notrun in common.dump if dump utils not found
Date: Sat, 22 Mar 2008 22:34:18 -0500 [thread overview]
Message-ID: <47E5CFBA.7060405@sandeen.net> (raw)
it may not always be obvious to outsiders that xfsdump is packaged
separately from xfsprogs... is it worth checking for the binaries
rather than spewing verbose failures if it's not installed?
(and are the locations ok for irix/bsd/whatnot too...?)
... also abort if bc not found (common.filter requires this,
my minimal testing root didn't have it and much error spew
ensued... nicer to check up front IMHO)
-Eric
Index: xfstests/common.dump
===================================================================
--- xfstests.orig/common.dump
+++ xfstests/common.dump
@@ -41,6 +41,10 @@ do_quota_check=true # do quota check if
_need_to_be_root
+[ -x /usr/sbin/xfsdump ] || _notrun "xfsdump executable not found"
+[ -x /usr/sbin/xfsrestore ] || _notrun "xfsrestore executable not found"
+[ -x /usr/sbin/xfsinvutil ] || _notrun "xfsinvutil executable not found"
+
# install our cleaner
trap "_cleanup; exit \$status" 0 1 2 3 15
Index: xfstests/common.config
===================================================================
--- xfstests.orig/common.config
+++ xfstests/common.config
@@ -114,6 +114,9 @@ export AWK_PROG="`set_prog_path awk`"
export SED_PROG="`set_prog_path sed`"
[ "$SED_PROG" = "" ] && _fatal "sed not found"
+export BC_PROG="`set_prog_path bc`"
+[ "$BC_PROG" = "" ] && _fatal "bc not found"
+
export PS_ALL_FLAGS="-ef"
export DF_PROG="`set_prog_path df`"
next reply other threads:[~2008-03-23 3:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-23 3:34 Eric Sandeen [this message]
[not found] ` <20080323054136.GA7529@puku.stupidest.org>
2008-03-23 20:29 ` [PATCH] xfsqa: call _notrun in common.dump if dump utils not found Eric Sandeen
2008-03-25 3:23 ` Timothy Shimmin
2008-03-25 3:35 ` Barry Naujok
2008-03-25 4:20 ` Eric Sandeen
2008-03-25 4:58 ` Timothy Shimmin
2008-03-25 6:05 ` Timothy Shimmin
2008-03-25 12:54 ` Eric Sandeen
2008-03-25 23:57 ` Timothy Shimmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E5CFBA.7060405@sandeen.net \
--to=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox