Re: [PATCH] xfsqa: call _notrun in common.dump if dump utils not found

[Timothy Shimmin <tes@sgi.com>]

Eric Sandeen wrote:
> Timothy Shimmin wrote:
>> Timothy Shimmin wrote:
>>  > Eric Sandeen wrote:
>>  >> Barry Naujok wrote:
>>  >>> On Tue, 25 Mar 2008 14:23:40 +1100, Timothy Shimmin <tes@sgi.com> wrote:
>>  >>>
>>  >>>> Thanks, Eric.
>>  >>>>
>>  >>>> On IRIX:
>>  >>>>  > where xfsdump xfsrestore xfsinvutil
>>  >>>> /sbin/xfsdump
>>  >>>> /usr/sbin/xfsdump
>>  >>>> /sbin/xfsrestore
>>  >>>> /usr/sbin/xfsinvutil
>>  >>>>  > ls -l /sbin/xfsdump
>>  >>>> lrwxr-xr-x    ... /sbin/xfsdump -> ../usr/sbin/xfsdump*
>>  >>>>
>>  >>>> I'll add the IRIX xfsrestore path and wait for Russell or
>>  >>>> whoever to complain about BSD :)
>>  >>> common.config sets up environment variables for the various
>>  >>> tools used and can handle these paths. It has them for the
>>  >>> xfsprogs tools (XFS_REPAIR_PROG, XFS_DB_PROG, etc) but
>>  >>> nothing for the xfsdump tools.
>>  >>
>>  >> yeah, that may be better...
>>  >>
>>  > Okay. Fair point.
>>  > I'll change common.dump to use the XFSDUMP_PROG etc....
>>  > and common.config to set the PROG vars.
>>  >
>>  > --Tim
>>  >
>>  >
>>
>> Okay, something like below then.
>> Note, I only test for failure in common.dump and I need
>> to filter out the fullpaths for the commands now as
>> they output their full path.
>> Oh and I changed a bit for the DEBUGDUMP which can
>> use binaries in xfstests for debugging.
>> Ughhh.
> 
> well, I don't want to make this too much work... it's not critical.
> 
:)
That's cool. It's Barry's fault ;-)

--Tim