Re: REVIEW: Write primary superblock info to ALL secondaries during mkfs

Eric Sandeen
2008-03-25T12:53:26Z

Barry Naujok wrote:
> Secondaries should contain redundant information from the primary
> superblock. It does this for the filesystem geometry information,
> but not inode values (rootino, rt inos, quota inos).
>
> This patch updates all the secondaries from the primary just before
> it marks the filesystem as good to go.
>
> Unfortunately, this also affects the output of xfs_repair during
> QA 030 and 178 which restores the primary superblock from the
> secondaries.
>
> Now that the secondaries have valid inode values, xfs_repair
> does not have to restore them to the correct values after copying
> the secondary into the primary.
>
> Attached is the mkfs.xfs patch and also the updated golden
> outputs for QA 030 and 178.
>
> The next step after this is to enhance xfs_repair to be more
> thorough in checking the secondaries during Phase 1.

One related thing I'd always wondered about was stamping a secondary at
the very end of the device (and therefore shrinking the fs by just a
bit) - repair could then do a quick check at the end of the device
before resorting to scanning for the 2nd backup... would this make any
sense?

-Eric