From: Eric Sandeen <sandeen@sandeen.net>
To: Timothy Shimmin <tes@sgi.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH, RFC] fix attr fit checking for filesystems which have lost their attr2
Date: Sun, 30 Mar 2008 20:45:09 -0500 [thread overview]
Message-ID: <47F04225.4030405@sandeen.net> (raw)
In-Reply-To: <47F035E3.1030004@sgi.com>
Timothy Shimmin wrote:
> Hi Eric,
>
> Eric Sandeen wrote:
...
>> My understanding of this is that if di_forkoff is non-zero,
>> we should always be using it for space calculations, regardless
>> of whether we are mounted with attr2 or not...
>>
> That was my understanding as well.
> I'll have a look at the code soon and see if I can
> see any problems with the change and the consistency
> of it all.
>
> Thanks a bunch,
> Tim.
Thanks. FWIW, if I install F8 with bona-fide attr2 in effect, with
selinux (so attrs on everything) and then update it while mounted as an
attr1 filesystem, with this patch in place, it does not result in
anything bad as far as xfs_repair can see. (and it's a big update,
probably touching most files...)
-Eric
next prev parent reply other threads:[~2008-03-31 1:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-29 4:56 [PATCH, RFC] fix attr fit checking for filesystems which have lost their attr2 Eric Sandeen
2008-03-31 0:52 ` Timothy Shimmin
2008-03-31 1:45 ` Eric Sandeen [this message]
2008-03-31 4:37 ` Timothy Shimmin
2008-03-31 6:11 ` Timothy Shimmin
2008-03-31 6:38 ` Timothy Shimmin
2008-03-31 13:32 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47F04225.4030405@sandeen.net \
--to=sandeen@sandeen.net \
--cc=tes@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox