public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Nishimoto <miken@agami.com>
To: XFS Mailing List <xfs@oss.sgi.com>
Subject: inconsistent xfs log record
Date: Mon, 07 Apr 2008 18:54:21 -0700	[thread overview]
Message-ID: <47FAD04D.5080308@agami.com> (raw)

I've just finished analyzing an xfs filesystem which won't recover.
An inconsistent log record has 332 log operations but the num_logop field
in the record header says 333 log operations.  The result is that xfs recovery
complains with "bad clientid" because recovery eventually attempts to decode
garbage.

The log record really has 332 log ops (I counted!).

Looking through xlog_write(), I don't see any way that record_cnt can be bumped
without also writing out a log operation.

Does this issue ring a bell with anyone?

    Michael

             reply	other threads:[~2008-04-08  4:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-08  1:54 Michael Nishimoto [this message]
2008-04-08 15:50 ` inconsistent xfs log record David Chinner
2008-04-08 16:14   ` Michael Nishimoto
2008-04-08 21:36   ` Michael Nishimoto
2008-04-09  2:30     ` David Chinner
2008-04-09  4:38 ` Timothy Shimmin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47FAD04D.5080308@agami.com \
    --to=miken@agami.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox