From: Donald Douwsma <donaldd@sgi.com>
To: David Chinner <dgc@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [patch] fix up xfsbdstrat b0rkage
Date: Thu, 10 Apr 2008 12:04:04 +1000 [thread overview]
Message-ID: <47FD7594.10206@sgi.com> (raw)
In-Reply-To: <20080410014737.GO108924158@sgi.com>
David Chinner wrote:
> Not sure how this got through testing, but it's screwed.
>
> ---
>
> Don't error out on good I/Os in xfsbdstrat().
>
> Signed-off-by: Dave Chinner <dgc@sgi.com>
> ---
> fs/xfs/linux-2.6/xfs_lrw.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Index: 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_lrw.c
> ===================================================================
> --- 2.6.x-xfs-new.orig/fs/xfs/linux-2.6/xfs_lrw.c 2008-04-10 11:02:30.000000000 +1000
> +++ 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_lrw.c 2008-04-10 11:40:54.533326543 +1000
> @@ -885,8 +885,10 @@ xfsbdstrat(
> struct xfs_buf *bp)
> {
> ASSERT(mp);
> - if (!XFS_FORCED_SHUTDOWN(mp))
> + if (!XFS_FORCED_SHUTDOWN(mp)) {
> xfs_buf_iorequest(bp);
> + return;
> + }
>
> xfs_buftrace("XFSBDSTRAT IOERROR", bp);
> xfs_bioerror_relse(bp);
Looks good Dave,
Don
prev parent reply other threads:[~2008-04-10 2:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 1:47 [patch] fix up xfsbdstrat b0rkage David Chinner
2008-04-10 2:04 ` Donald Douwsma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47FD7594.10206@sgi.com \
--to=donaldd@sgi.com \
--cc=dgc@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox