* [patch] fix up xfsbdstrat b0rkage
@ 2008-04-10 1:47 David Chinner
2008-04-10 2:04 ` Donald Douwsma
0 siblings, 1 reply; 2+ messages in thread
From: David Chinner @ 2008-04-10 1:47 UTC (permalink / raw)
To: xfs-dev; +Cc: xfs-oss
Not sure how this got through testing, but it's screwed.
---
Don't error out on good I/Os in xfsbdstrat().
Signed-off-by: Dave Chinner <dgc@sgi.com>
---
fs/xfs/linux-2.6/xfs_lrw.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Index: 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_lrw.c
===================================================================
--- 2.6.x-xfs-new.orig/fs/xfs/linux-2.6/xfs_lrw.c 2008-04-10 11:02:30.000000000 +1000
+++ 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_lrw.c 2008-04-10 11:40:54.533326543 +1000
@@ -885,8 +885,10 @@ xfsbdstrat(
struct xfs_buf *bp)
{
ASSERT(mp);
- if (!XFS_FORCED_SHUTDOWN(mp))
+ if (!XFS_FORCED_SHUTDOWN(mp)) {
xfs_buf_iorequest(bp);
+ return;
+ }
xfs_buftrace("XFSBDSTRAT IOERROR", bp);
xfs_bioerror_relse(bp);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch] fix up xfsbdstrat b0rkage
2008-04-10 1:47 [patch] fix up xfsbdstrat b0rkage David Chinner
@ 2008-04-10 2:04 ` Donald Douwsma
0 siblings, 0 replies; 2+ messages in thread
From: Donald Douwsma @ 2008-04-10 2:04 UTC (permalink / raw)
To: David Chinner; +Cc: xfs-dev, xfs-oss
David Chinner wrote:
> Not sure how this got through testing, but it's screwed.
>
> ---
>
> Don't error out on good I/Os in xfsbdstrat().
>
> Signed-off-by: Dave Chinner <dgc@sgi.com>
> ---
> fs/xfs/linux-2.6/xfs_lrw.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Index: 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_lrw.c
> ===================================================================
> --- 2.6.x-xfs-new.orig/fs/xfs/linux-2.6/xfs_lrw.c 2008-04-10 11:02:30.000000000 +1000
> +++ 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_lrw.c 2008-04-10 11:40:54.533326543 +1000
> @@ -885,8 +885,10 @@ xfsbdstrat(
> struct xfs_buf *bp)
> {
> ASSERT(mp);
> - if (!XFS_FORCED_SHUTDOWN(mp))
> + if (!XFS_FORCED_SHUTDOWN(mp)) {
> xfs_buf_iorequest(bp);
> + return;
> + }
>
> xfs_buftrace("XFSBDSTRAT IOERROR", bp);
> xfs_bioerror_relse(bp);
Looks good Dave,
Don
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-10 2:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-10 1:47 [patch] fix up xfsbdstrat b0rkage David Chinner
2008-04-10 2:04 ` Donald Douwsma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox