From: Eric Sandeen <sandeen@sandeen.net>
To: Timothy Shimmin <tes@sgi.com>
Cc: Andi Kleen <andi@firstfloor.org>, David Chinner <dgc@sgi.com>,
Niv Sardi <xaiki@cxhome.ath.cx>, Christoph Hellwig <hch@lst.de>,
xfs@oss.sgi.com
Subject: Re: likely and unlikely was: Re: [PATCH] split xfs_ioc_xattr
Date: Fri, 18 Apr 2008 09:05:25 -0500 [thread overview]
Message-ID: <4808AAA5.1060201@sandeen.net> (raw)
In-Reply-To: <4808488A.7010204@sgi.com>
Timothy Shimmin wrote:
> Hi,
>
> Thanks for the explanation, Andi.
> So I guess the upshot is, that it can make a difference but
> in many cases (where the perf difference isn't an issue)
> it is probably not worth the ugliness.
> And in performance cases, it would be best to test the hypothesis
> with the unlikely profiler patch
> => it will be _unlikely_ we will bother ;-)
> So I don't think I'll be bothering with them then unless
> an issue comes up :)
>
> --Tim
ISTR that the dir2 code on Irix had tons of compiler pragmas for likely
and unlikely paths, and that it actually was well-profiled and tested.
Did that ever get translated into Linux hints?
-Eric
next prev parent reply other threads:[~2008-04-18 14:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-19 20:40 [PATCH] split xfs_ioc_xattr Christoph Hellwig
2008-04-14 3:14 ` Niv Sardi
2008-04-14 3:29 ` Christoph Hellwig
2008-04-16 3:47 ` Niv Sardi
2008-04-16 6:37 ` David Chinner
2008-04-16 7:06 ` Timothy Shimmin
2008-04-16 7:29 ` Andi Kleen
2008-04-18 7:06 ` likely and unlikely was: " Timothy Shimmin
2008-04-18 13:34 ` Andi Kleen
2008-04-18 14:05 ` Eric Sandeen [this message]
2008-04-21 0:33 ` David Chinner
2008-04-21 7:55 ` Andi Kleen
2008-04-21 21:41 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4808AAA5.1060201@sandeen.net \
--to=sandeen@sandeen.net \
--cc=andi@firstfloor.org \
--cc=dgc@sgi.com \
--cc=hch@lst.de \
--cc=tes@sgi.com \
--cc=xaiki@cxhome.ath.cx \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox