PARTIAL TAKE 976035 - kill usesless IHOLD calls in xfs_rename

PARTIAL TAKE 976035 - kill usesless IHOLD calls in xfs_rename

[Lachlan McIlroy]

kill usesless IHOLD calls in xfs_rename

Similar to to the previous patch for remove and rmdir only grab
a reference to inodes when we join them to transaction to balance the
decrement on transaction completion.  Everything else it taken care of
by the VFS.

Note that the old case had leaks of inode count when src == target or
src or target == one of the parent inodes, but these cases are
fortunately already rejected by the VFS.


Signed-off-by: Christoph Hellwig <hch@lst.de>

Date:  Mon Apr 21 15:23:49 AEST 2008
Workarea:  redback.melbourne.sgi.com:/home/lachlan/isms/2.6.x-hch
Inspected by:  hch
Author:  lachlan

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:30904a
fs/xfs/xfs_rename.c - 1.84 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_rename.c.diff?r1=text&tr1=1.84&r2=text&tr2=1.83&f=h
	- kill usesless IHOLD calls in xfs_rename

Re: PARTIAL TAKE 976035 - kill usesless IHOLD calls in xfs_rename

[Christoph Hellwig]

Any reason you didn't commit:

  [PATCH 1/2] kill parent == child checks in xfs_remove and xfs_rmdir
  [PATCH 2/2] kill usesless IHOLD calls in xfs_remove and xfs_rmdir

in this round, it's pretty much the equivalent treatment to remove and
rmdir that we did to rename in this and the previous patch.

Re: PARTIAL TAKE 976035 - kill usesless IHOLD calls in xfs_rename

[Lachlan McIlroy]

Christoph Hellwig wrote:
> Any reason you didn't commit:
> 
>   [PATCH 1/2] kill parent == child checks in xfs_remove and xfs_rmdir
>   [PATCH 2/2] kill usesless IHOLD calls in xfs_remove and xfs_rmdir
> 
> in this round, it's pretty much the equivalent treatment to remove and
> rmdir that we did to rename in this and the previous patch.
> 

No intentional reason.  For some reason I didn't apply them when I tested
the last batch.  They're going through QA now and I'll check them in soon.