* [PATCH] convert xfs to use ERR_CAST
@ 2008-04-23 21:16 Eric Sandeen
2008-04-25 8:59 ` Christoph Hellwig
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Eric Sandeen @ 2008-04-23 21:16 UTC (permalink / raw)
To: xfs mailing list; +Cc: David Howells
Looks like somehow xfs got missed in the conversion that
took place in e231c2ee64eb1c5cd3c63c31da9dac7d888dcf7f,
"Convert ERR_PTR(PTR_ERR(p)) instances to ERR_CAST(p) <http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e231c2ee64eb1c5cd3c63c31da9dac7d888dcf7f>"
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---
ndex: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_export.c
===================================================================
--- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_export.c
+++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_export.c
@@ -167,7 +167,7 @@ xfs_fs_fh_to_dentry(struct super_block *
if (!inode)
return NULL;
if (IS_ERR(inode))
- return ERR_PTR(PTR_ERR(inode));
+ return ERR_CAST(inode);
result = d_alloc_anon(inode);
if (!result) {
iput(inode);
@@ -198,7 +198,7 @@ xfs_fs_fh_to_parent(struct super_block *
if (!inode)
return NULL;
if (IS_ERR(inode))
- return ERR_PTR(PTR_ERR(inode));
+ return ERR_CAST(inode);
result = d_alloc_anon(inode);
if (!result) {
iput(inode);
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] convert xfs to use ERR_CAST
2008-04-23 21:16 [PATCH] convert xfs to use ERR_CAST Eric Sandeen
@ 2008-04-25 8:59 ` Christoph Hellwig
2008-04-25 9:55 ` David Howells
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2008-04-25 8:59 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs mailing list, David Howells
On Wed, Apr 23, 2008 at 04:16:39PM -0500, Eric Sandeen wrote:
> Looks like somehow xfs got missed in the conversion that
> took place in e231c2ee64eb1c5cd3c63c31da9dac7d888dcf7f,
> "Convert ERR_PTR(PTR_ERR(p)) instances to ERR_CAST(p) <http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e231c2ee64eb1c5cd3c63c31da9dac7d888dcf7f>"
Looks good.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] convert xfs to use ERR_CAST
2008-04-23 21:16 [PATCH] convert xfs to use ERR_CAST Eric Sandeen
2008-04-25 8:59 ` Christoph Hellwig
@ 2008-04-25 9:55 ` David Howells
2008-07-08 2:55 ` Eric Sandeen
2008-07-24 8:21 ` Niv Sardi
3 siblings, 0 replies; 5+ messages in thread
From: David Howells @ 2008-04-25 9:55 UTC (permalink / raw)
To: Eric Sandeen; +Cc: dhowells, xfs mailing list
Eric Sandeen <sandeen@sandeen.net> wrote:
> Looks like somehow xfs got missed in the conversion that
> took place in e231c2ee64eb1c5cd3c63c31da9dac7d888dcf7f,
> "Convert ERR_PTR(PTR_ERR(p)) instances to ERR_CAST(p) <http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e231c2ee64eb1c5cd3c63c31da9dac7d888dcf7f>"
>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Acked-by: David Howells <dhowells@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] convert xfs to use ERR_CAST
2008-04-23 21:16 [PATCH] convert xfs to use ERR_CAST Eric Sandeen
2008-04-25 8:59 ` Christoph Hellwig
2008-04-25 9:55 ` David Howells
@ 2008-07-08 2:55 ` Eric Sandeen
2008-07-24 8:21 ` Niv Sardi
3 siblings, 0 replies; 5+ messages in thread
From: Eric Sandeen @ 2008-07-08 2:55 UTC (permalink / raw)
To: xfs mailing list
Eric Sandeen wrote:
> Looks like somehow xfs got missed in the conversion that
> took place in e231c2ee64eb1c5cd3c63c31da9dac7d888dcf7f,
> "Convert ERR_PTR(PTR_ERR(p)) instances to ERR_CAST(p) <http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e231c2ee64eb1c5cd3c63c31da9dac7d888dcf7f>"
>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> ---
ping.
This one's really, really, really easy :)
-Eric
> ndex: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_export.c
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_export.c
> +++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_export.c
> @@ -167,7 +167,7 @@ xfs_fs_fh_to_dentry(struct super_block *
> if (!inode)
> return NULL;
> if (IS_ERR(inode))
> - return ERR_PTR(PTR_ERR(inode));
> + return ERR_CAST(inode);
> result = d_alloc_anon(inode);
> if (!result) {
> iput(inode);
> @@ -198,7 +198,7 @@ xfs_fs_fh_to_parent(struct super_block *
> if (!inode)
> return NULL;
> if (IS_ERR(inode))
> - return ERR_PTR(PTR_ERR(inode));
> + return ERR_CAST(inode);
> result = d_alloc_anon(inode);
> if (!result) {
> iput(inode);
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] convert xfs to use ERR_CAST
2008-04-23 21:16 [PATCH] convert xfs to use ERR_CAST Eric Sandeen
` (2 preceding siblings ...)
2008-07-08 2:55 ` Eric Sandeen
@ 2008-07-24 8:21 ` Niv Sardi
3 siblings, 0 replies; 5+ messages in thread
From: Niv Sardi @ 2008-07-24 8:21 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs mailing list, David Howells
in
--
Niv Sardi
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-07-24 8:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-23 21:16 [PATCH] convert xfs to use ERR_CAST Eric Sandeen
2008-04-25 8:59 ` Christoph Hellwig
2008-04-25 9:55 ` David Howells
2008-07-08 2:55 ` Eric Sandeen
2008-07-24 8:21 ` Niv Sardi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox