From: Lachlan McIlroy <lachlan@sgi.com>
To: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH] make inode reclaim wait for log I/O to complete
Date: Wed, 14 May 2008 15:24:57 +1000 [thread overview]
Message-ID: <482A77A9.5040806@sgi.com> (raw)
An xfs inode can be destroyed before log I/O involving that inode
is complete. We need to wait for the inode to be unpinned before
tearing it down.
Lachlan
--- fs/xfs/xfs_inode.c_1.501 2008-05-12 14:45:17.000000000 +1000
+++ fs/xfs/xfs_inode.c 2008-05-12 12:23:48.000000000 +1000
@@ -2787,7 +2787,7 @@ __xfs_iunpin_wait(
wait_event(ip->i_ipin_wait, (atomic_read(&ip->i_pincount) == 0));
}
-static inline void
+inline void
xfs_iunpin_wait(
xfs_inode_t *ip)
{
--- fs/xfs/xfs_inode.h_1.245 2008-05-12 14:45:20.000000000 +1000
+++ fs/xfs/xfs_inode.h 2008-05-12 12:31:37.000000000 +1000
@@ -481,6 +481,7 @@ void xfs_ifunlock(xfs_inode_t *);
void xfs_ireclaim(xfs_inode_t *);
int xfs_finish_reclaim(xfs_inode_t *, int, int);
int xfs_finish_reclaim_all(struct xfs_mount *, int);
+void xfs_iunpin_wait(xfs_inode_t *);
/*
* xfs_inode.c prototypes.
--- fs/xfs/xfs_vnodeops.c_1.757 2008-05-12 12:02:45.000000000 +1000
+++ fs/xfs/xfs_vnodeops.c 2008-05-12 12:28:15.000000000 +1000
@@ -3324,6 +3324,7 @@ xfs_finish_reclaim(
* because we're gonna reclaim the inode anyway.
*/
if (error) {
+ xfs_iunpin_wait(ip);
xfs_iunlock(ip, XFS_ILOCK_EXCL);
goto reclaim;
}
@@ -3336,6 +3337,7 @@ xfs_finish_reclaim(
}
xfs_ifunlock(ip);
+ xfs_iunpin_wait(ip);
xfs_iunlock(ip, XFS_ILOCK_EXCL);
reclaim:
next reply other threads:[~2008-05-14 5:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 5:24 Lachlan McIlroy [this message]
2008-05-14 6:44 ` [PATCH] make inode reclaim wait for log I/O to complete David Chinner
2008-05-22 3:42 ` Lachlan McIlroy
2008-05-22 4:31 ` David Chinner
2008-05-22 8:23 ` Lachlan McIlroy
2008-05-22 23:55 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482A77A9.5040806@sgi.com \
--to=lachlan@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox