public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Tomas Racek <tracek@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: lczerner@redhat.com, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: Don't require to set $TEST_DEV and $TEST_DIR when creating new script
Date: Tue, 31 Jul 2012 06:41:12 -0400 (EDT)	[thread overview]
Message-ID: <483754529.1252527.1343731272189.JavaMail.root@redhat.com> (raw)
In-Reply-To: <20120730215630.GH2877@dastard>

> > 
> >    #  Mandatory Config values.
> >    MC=""
> > -  [ -z "$EMAIL" ]          && MC="$MC EMAIL"
> > -  [ -z "$TEST_DIR" ]       && MC="$MC TEST_DIR"
> > -  [ -z "$TEST_DEV" ]       && MC="$MC TEST_DEV"
> > +  [ -z "$EMAIL" ]                           && MC="$MC EMAIL"
> > +  [ -z "$TEST_DIR" ] && [ "$iam" != "new" ] && MC="$MC TEST_DIR"
> > +  [ -z "$TEST_DEV" ] && [ "$iam" != "new" ] && MC="$MC TEST_DEV"
> 
> Given that I'm currently in the process of killing $iam as I
> rework the structure of xfstests, I really don't like the idea of
> introducing new dependencies on it.

OK, I didn't know that. ;-)

> Also, I prefer to know that someone writing a new test is developing
> it in a configured, working test environment. After all, you have to
> test your new test as you write it... :p

I thought that is not necessary to depend on those if new script doesn't require them but I can see your point.

Thanks for comments!

Tomas

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2012-07-31 10:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-30 12:03 [PATCH] xfstests: Don't require to set $TEST_DEV and $TEST_DIR when creating new script Tomas Racek
2012-07-30 21:56 ` Dave Chinner
2012-07-31 10:41   ` Tomas Racek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=483754529.1252527.1343731272189.JavaMail.root@redhat.com \
    --to=tracek@redhat.com \
    --cc=david@fromorbit.com \
    --cc=lczerner@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox