Re: REVIEW: Enhance xfs_repair -P option to disable libxfs xfs_buf_t locking

[Eric Sandeen <sandeen@sandeen.net>]

Barry Naujok wrote:
> On Fri, 30 May 2008 10:52:23 +1000, Eric Sandeen <sandeen@sandeen.net>  
> wrote:
> 
>> Barry Naujok wrote:
>>> I hope the subject is explanation enough :)
>> not really ;)
>>
>> Hum, if I normally lock why do I not want to lock?  Locking good?
>> Locking bad?  Locking too slow?  locking for what?  Incoherency ok?  Man
>> page updates? :)
>>
> 
> Ok, man page update:

I like it.  Thanks!

-Eric

> --- a/xfsprogs/man/man8/xfs_repair.8    2008-05-30 11:11:41.000000000 +1000
> +++ b/xfsprogs/man/man8/xfs_repair.8    2008-05-30 11:10:24.075877526 +1000
> @@ -91,6 +91,14 @@
>   should not modify the filesystem but should only scan the
>   filesystem and indicate what repairs would have been made.
>   .TP
> +.B \-P
> +Disable prefetching of inode and directory blocks. Use this option if
> +you find
> +.B xfs_repair
> +gets stuck and stops proceeding. Interrupting a stuck
> +.B xfs_repair
> +is safe.
> +.TP
>   .BI \-m " maxmem"
>   Specifies the approximate maximum amount of memory, in megabytes, to use  
> for
>   .BR xfs_repair .
> @@ -146,9 +154,6 @@
>   outputs its progress every 15 minutes. Reporting is only activated when
>   ag_stride is enabled.
>   .TP
> -.B \-P
> -Disable prefetching of inode and directory blocks.
> -.TP
>   .B \-v
>   Verbose output.
>   .TP
> 
>