Re: rfc: kill ino64 mount option

Nathan Scott
2008-06-29T23:14:02Z

On Sat, 2008-06-28 at 17:23 +0200, Christoph Hellwig wrote:
> On Sat, Jun 28, 2008 at 10:09:14AM +1000, Dave Chinner wrote:
> > On Fri, Jun 27, 2008 at 05:39:28PM +0200, Christoph Hellwig wrote:
> > > Does anyone have objections to kill the ino64 mount option? It's purely
> > > a debug tool to force inode numbers outside of the range representable
> > > in 32bits and is quite invasive for something that could easily be
> > > debugged by just having a large enough filesystem..
> >
> > It's the "large enough fs" that is the problem. XFSQA uses
> > small partitions for the most part, and this allows testing
> > of 64 bit inode numbers with a standard qa config.
>
> Well, it allows showing 64bit inode numbers to userspace. All XFS
> internal codepathes are still using the smaller inode numbers and we
> only add a fixed offset to them just before the inode number is returned
> to userspace.

I'd vote for removing it - I've used it in the past, and it didn't do
what I wanted (its not really useful for XFS testing) and the confusion
it causes with inode64 is not worth it.

cheers.

--
Nathan