From: Timothy Shimmin <tes@sgi.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] kill XFS_PURGE_INODE
Date: Fri, 04 Jul 2008 15:15:05 +1000 [thread overview]
Message-ID: <486DB1D9.20207@sgi.com> (raw)
In-Reply-To: <20080702192224.GB18817@lst.de>
Christoph Hellwig wrote:
> Ping? Already got a review from Dave.
>
Yeah, this is basically a substitute and replace.
Okay, looks like there is also a s/VN_HOLD(XFS_ITOV())/IHOLD()/
thrown in too (which is what IHOLD is defined as).
I'll check it in.
--Tim
> On Mon, Jun 16, 2008 at 08:26:34AM +0200, Christoph Hellwig wrote:
>> Just a useless alias for IRELE.
>>
>>
>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>>
>> Index: linux-2.6-xfs/fs/xfs/quota/xfs_qm.c
>> ===================================================================
>> --- linux-2.6-xfs.orig/fs/xfs/quota/xfs_qm.c 2008-06-05 20:21:04.000000000 +0200
>> +++ linux-2.6-xfs/fs/xfs/quota/xfs_qm.c 2008-06-05 20:22:37.000000000 +0200
>> @@ -444,11 +444,11 @@ xfs_qm_unmount_quotas(
>> }
>> }
>> if (uqp) {
>> - XFS_PURGE_INODE(uqp);
>> + IRELE(uqp);
>> mp->m_quotainfo->qi_uquotaip = NULL;
>> }
>> if (gqp) {
>> - XFS_PURGE_INODE(gqp);
>> + IRELE(gqp);
>> mp->m_quotainfo->qi_gquotaip = NULL;
>> }
>> out:
>> @@ -1239,11 +1239,11 @@ xfs_qm_destroy_quotainfo(
>> xfs_qm_list_destroy(&qi->qi_dqlist);
>>
>> if (qi->qi_uquotaip) {
>> - XFS_PURGE_INODE(qi->qi_uquotaip);
>> + IRELE(qi->qi_uquotaip);
>> qi->qi_uquotaip = NULL; /* paranoia */
>> }
>> if (qi->qi_gquotaip) {
>> - XFS_PURGE_INODE(qi->qi_gquotaip);
>> + IRELE(qi->qi_gquotaip);
>> qi->qi_gquotaip = NULL;
>> }
>> mutex_destroy(&qi->qi_quotaofflock);
>> @@ -1393,7 +1393,7 @@ xfs_qm_qino_alloc(
>> * locked exclusively and joined to the transaction already.
>> */
>> ASSERT(xfs_isilocked(*ip, XFS_ILOCK_EXCL));
>> - VN_HOLD(XFS_ITOV((*ip)));
>> + IHOLD(*ip);
>>
>> /*
>> * Make the changes in the superblock, and log those too.
>> Index: linux-2.6-xfs/fs/xfs/quota/xfs_qm_syscalls.c
>> ===================================================================
>> --- linux-2.6-xfs.orig/fs/xfs/quota/xfs_qm_syscalls.c 2008-05-23 09:31:39.000000000 +0200
>> +++ linux-2.6-xfs/fs/xfs/quota/xfs_qm_syscalls.c 2008-06-05 20:21:09.000000000 +0200
>> @@ -362,11 +362,11 @@ xfs_qm_scall_quotaoff(
>> * if we don't need them anymore.
>> */
>> if ((dqtype & XFS_QMOPT_UQUOTA) && XFS_QI_UQIP(mp)) {
>> - XFS_PURGE_INODE(XFS_QI_UQIP(mp));
>> + IRELE(XFS_QI_UQIP(mp));
>> XFS_QI_UQIP(mp) = NULL;
>> }
>> if ((dqtype & (XFS_QMOPT_GQUOTA|XFS_QMOPT_PQUOTA)) && XFS_QI_GQIP(mp)) {
>> - XFS_PURGE_INODE(XFS_QI_GQIP(mp));
>> + IRELE(XFS_QI_GQIP(mp));
>> XFS_QI_GQIP(mp) = NULL;
>> }
>> out_error:
>> Index: linux-2.6-xfs/fs/xfs/quota/xfs_quota_priv.h
>> ===================================================================
>> --- linux-2.6-xfs.orig/fs/xfs/quota/xfs_quota_priv.h 2008-05-23 09:31:39.000000000 +0200
>> +++ linux-2.6-xfs/fs/xfs/quota/xfs_quota_priv.h 2008-06-05 20:21:09.000000000 +0200
>> @@ -158,9 +158,6 @@ for ((dqp) = (qlist)->qh_next; (dqp) !=
>> #define XFS_IS_SUSER_DQUOT(dqp) \
>> (!((dqp)->q_core.d_id))
>>
>> -#define XFS_PURGE_INODE(ip) \
>> - IRELE(ip);
>> -
>> #define DQFLAGTO_TYPESTR(d) (((d)->dq_flags & XFS_DQ_USER) ? "USR" : \
>> (((d)->dq_flags & XFS_DQ_GROUP) ? "GRP" : \
>> (((d)->dq_flags & XFS_DQ_PROJ) ? "PRJ":"???")))
> ---end quoted text---
>
prev parent reply other threads:[~2008-07-04 5:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-16 6:26 [PATCH] kill XFS_PURGE_INODE Christoph Hellwig
2008-06-16 17:15 ` Dave Chinner
2008-06-20 6:18 ` Christoph Hellwig
2008-07-02 19:22 ` Christoph Hellwig
2008-07-04 5:15 ` Timothy Shimmin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486DB1D9.20207@sgi.com \
--to=tes@sgi.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox