From: Mark Goodwin <markgw@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 2/4] XFS: Use the inode tree for finding dirty inodes
Date: Wed, 23 Jul 2008 15:00:57 +1000 [thread overview]
Message-ID: <4886BB09.3080400@sgi.com> (raw)
In-Reply-To: <4886AF06.40808@sandeen.net>
Eric Sandeen wrote:
> Mark Goodwin wrote:
>
>> As above, just run QA for cleanups.
>
> Out of curiosity, will you trust this? You'll run QA anyway, right?
yes we run it anyway, so maybe this (as a requirement) is overkill.
> And do you very often find errors in submitted patches by running QA?
>
don't know, but it is part of the review process. For cleanups,
bugs/regressions seem to be fairly rare (hence they're subtle and
unexpected). I think you found one such regression a while back,
(after a herculean effort).
Cheers
-- Mark
next prev parent reply other threads:[~2008-07-23 5:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-20 12:19 [PATCH 0/4] XFS: replace the mount inode list with radix tree traversals Dave Chinner
2008-07-20 12:19 ` [PATCH 1/4] XFS: Remove xfs_iflush_all and clean up xfs_finish_reclaim_all() Dave Chinner
2008-07-21 7:58 ` Christoph Hellwig
2008-07-21 11:33 ` Dave Chinner
2008-07-22 4:24 ` Christoph Hellwig
2008-07-20 12:19 ` [PATCH 2/4] XFS: Use the inode tree for finding dirty inodes Dave Chinner
2008-07-22 4:28 ` Christoph Hellwig
2008-07-22 5:30 ` Dave Chinner
2008-07-22 7:27 ` Christoph Hellwig
2008-07-23 0:05 ` Dave Chinner
2008-07-23 2:10 ` Mark Goodwin
2008-07-23 3:46 ` Eric Sandeen
2008-07-23 4:04 ` Mark Goodwin
2008-07-23 4:09 ` Eric Sandeen
2008-07-23 5:00 ` Mark Goodwin [this message]
2008-07-23 4:27 ` Dave Chinner
2008-07-23 4:18 ` Dave Chinner
2008-07-23 15:37 ` Russell Cattelan
2008-07-24 6:02 ` Mark Goodwin
2008-07-25 3:55 ` Russell Cattelan
2008-07-25 4:08 ` Mark Goodwin
2008-07-25 5:40 ` Russell Cattelan
2008-07-25 6:55 ` Niv Sardi
2008-07-23 20:49 ` Christoph Hellwig
2008-07-24 11:46 ` Dave Chinner
2008-07-20 12:19 ` [PATCH 3/4] XFS: Traverse inode trees when releasing dquots Dave Chinner
2008-07-20 12:19 ` [PATCH 4/4] XFS: remove the mount inode list Dave Chinner
2008-07-22 4:29 ` Christoph Hellwig
2008-07-22 5:42 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4886BB09.3080400@sgi.com \
--to=markgw@sgi.com \
--cc=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox