From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: with ECARTIS (v1.0.0; list xfs); Wed, 23 Jul 2008 16:58:00 -0700 (PDT) Received: from cuda.sgi.com ([192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id m6NNvuwZ007801 for ; Wed, 23 Jul 2008 16:57:57 -0700 Received: from slurp.thebarn.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 76080191E87F for ; Wed, 23 Jul 2008 16:59:06 -0700 (PDT) Received: from slurp.thebarn.com (cattelan-host202.dsl.visi.com [208.42.117.202]) by cuda.sgi.com with ESMTP id kn43MClujJ03FUnZ for ; Wed, 23 Jul 2008 16:59:06 -0700 (PDT) Message-ID: <4887C5C2.7080500@thebarn.com> Date: Wed, 23 Jul 2008 18:58:58 -0500 From: Russell Cattelan MIME-Version: 1.0 Subject: Re: [PATCH 0/2] kill bhv_vnode_t References: <20080723214737.GA10655@lst.de> <4887A84D.90701@thebarn.com> <20080723215721.GA11049@lst.de> In-Reply-To: <20080723215721.GA11049@lst.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com List-Id: xfs To: Christoph Hellwig Cc: xfs@oss.sgi.com Christoph Hellwig wrote: > On Wed, Jul 23, 2008 at 04:53:17PM -0500, Russell Cattelan wrote: > >> Christoph Hellwig wrote: >> >>> Dave complained today that the fate of bhv_vnode_t isn't entirely clear >>> yet, so I've prepared these two patches to kill it in a minimally >>> invasive way. While it causes churn in a lot of areas it does not >>> affect the generated code at all. >>> >>> >>> >> I know a bunch of stuff has gone in that is not very portable, which is >> fine since >> they can be dealt with individually since they are not that intrusive. >> >> Changing bhv_vnode_t to struct inode throughout the code is a pretty big >> change and would be a major pain to work around. >> > > Have you actually looed at the patches? The only places where we use > struct inode outside of linux-2.6/ are: > > - xfs_finish_reclaim: > > Distangles the xfs_inode from Linux inode. Per defintion > OS-specific. > > - xfs_sync_inodes: > > Sync code that is quite OS specific. Dave will move it > to linux-2.6/ pretty soon. > > - quota/xfs_qm_syscalls.c: > > Similar sync code. > > - xfs_acl.c: > > ACL code with some OS dependencies, and pretty dead with my > pending patch to use the generic ACL code. > > And no, it's not actually a big change. > > I guess it's not that big of a change anymore. I really need to find some time and get fbsd synced up with the latest xfs code. -Russell