From: Lachlan McIlroy <lachlan@sgi.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/5] kill vn_from_inode
Date: Thu, 24 Jul 2008 17:57:43 +1000 [thread overview]
Message-ID: <488835F7.3040007@sgi.com> (raw)
In-Reply-To: <20080723194934.GB6188@lst.de>
Yep, good stuff.
Christoph Hellwig wrote:
> bhv_vnode_t is just a typedef for struct inode, so there's no need for
> a helper to convert between the two.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_super.c
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_super.c 2008-07-23 19:29:16.000000000 +0200
> +++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_super.c 2008-07-23 19:29:22.000000000 +0200
> @@ -994,7 +994,7 @@ STATIC void
> xfs_fs_destroy_inode(
> struct inode *inode)
> {
> - kmem_zone_free(xfs_vnode_zone, vn_from_inode(inode));
> + kmem_zone_free(xfs_vnode_zone, inode);
> }
>
> STATIC void
> Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_vnode.h
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_vnode.h 2008-07-23 19:29:26.000000000 +0200
> +++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_vnode.h 2008-07-23 19:29:52.000000000 +0200
> @@ -27,10 +27,6 @@ typedef struct inode bhv_vnode_t;
> /*
> * Vnode to Linux inode mapping.
> */
> -static inline bhv_vnode_t *vn_from_inode(struct inode *inode)
> -{
> - return inode;
> -}
> static inline struct inode *vn_to_inode(bhv_vnode_t *vnode)
> {
> return vnode;
> @@ -100,8 +96,7 @@ extern bhv_vnode_t *vn_hold(bhv_vnode_t
>
> static inline bhv_vnode_t *vn_grab(bhv_vnode_t *vp)
> {
> - struct inode *inode = igrab(vn_to_inode(vp));
> - return inode ? vn_from_inode(inode) : NULL;
> + return igrab(vn_to_inode(vp));
> }
>
> /*
>
>
>
prev parent reply other threads:[~2008-07-24 7:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-23 19:49 [PATCH 1/5] kill vn_from_inode Christoph Hellwig
2008-07-24 7:57 ` Lachlan McIlroy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488835F7.3040007@sgi.com \
--to=lachlan@sgi.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox