Re: [PATCH 2/4] XFS: Use the inode tree for finding dirty inodes

Mark Goodwin
2008-07-23T04:03:12Z

Eric Sandeen wrote:
> Mark Goodwin wrote:
>> Dave Chinner wrote:
>>> On Tue, Jul 22, 2008 at 03:27:33AM -0400, Christoph Hellwig wrote:
>>>> ...
>>>> I only fear
>>>> we'll never get it in with the current review and commit latencies
>>>> for XFS :(
>>> I can see this being a big issue in the not-too-distant future.....
>> [getting off-topic for this thread, but anyway ..]
>> This is already a big issue, obviously, and has been for some time.
>>
>> Internally, we're attempting to refine our patch acceptance processes,
>> (e.g. gitify our internal dev tree and mirror it on oss so it's much
>> easier to push back out to oss). But the QA overhead remains a stubborn
>> problem. I think we're going to have to ask for QA tests (both regression
>> and performance) to be written as part of the patch acceptance policy -
>> under this policy, merely passing existing QA will not be sufficient.
>> Comments?
>
> I think that'll depend very much on what the change is. For new
> functionality, sounds good; for bugfixes with testcases, sounds good.

and for cleanups, just run existing QA (new test wouldn't normally make
sense).

> For general algorithm improvements... how do you write a new QA test for
> "Use the inode tree for finding dirty inodes?"

Case by case basis I guess. e.g. write a test that exercises or stresses
the changed algorithm or functionality, especially corner cases (low
space, full AGs, mem pressure, whatever). Performance regression testing
is trickier - need access to suitable h/w and the historical data; so it's
probably best run on dedicated h/w every night against the dev tree.

> Or for that matter, my
> remaining 2 shouting-removal patches ;)

As above, just run QA for cleanups.

>
>> We have recently set up external access to a system for QA and
>> regression testing for Christoph's use .. perhaps that should
>> be a permanent offering?
>
> Sounds awesome, for serious contributors. I'd be happy to use it, too ;)
>
> -Eric
>
>

--

Mark Goodwin markgw@sgi.com
Engineering Manager for XFS and PCP Phone: +61-3-99631937
SGI Australian Software Group Cell: +61-4-18969583
-------------------------------------------------------------