* TAKE 981498 - kill bhv_vnode_t
@ 2008-07-28 6:26 Lachlan McIlroy
2008-07-28 12:15 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Lachlan McIlroy @ 2008-07-28 6:26 UTC (permalink / raw)
To: sgi.bugs.xfs, xfs
kill bhv_vnode_t
All remaining bhv_vnode_t instance are in code that's more or less Linux
specific. (Well, for xfs_acl.c that could be argued, but that code is
on the removal list, too). So just do an s/bhv_vnode_t/struct inode/
over the whole tree. We can clean up variable naming and some useless
helpers later.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Date: Mon Jul 28 16:25:27 AEST 2008
Workarea: redback.melbourne.sgi.com:/home/lachlan/isms/2.6.x-hch
Inspected by:
hch
lachlan
Author: lachlan
The following file(s) were checked into:
longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb
Modid: xfs-linux-melb:xfs-kern:31781a
fs/xfs/xfs_vnodeops.c - 1.771 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_vnodeops.c.diff?r1=text&tr1=1.771&r2=text&tr2=1.770&f=h
fs/xfs/xfs_vfsops.c - 1.574 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_vfsops.c.diff?r1=text&tr1=1.574&r2=text&tr2=1.573&f=h
fs/xfs/xfs_acl.h - 1.39 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_acl.h.diff?r1=text&tr1=1.39&r2=text&tr2=1.38&f=h
fs/xfs/xfs_acl.c - 1.79 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_acl.c.diff?r1=text&tr1=1.79&r2=text&tr2=1.78&f=h
fs/xfs/xfs_inode.c - 1.513 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_inode.c.diff?r1=text&tr1=1.513&r2=text&tr2=1.512&f=h
fs/xfs/xfs_inode.h - 1.254 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_inode.h.diff?r1=text&tr1=1.254&r2=text&tr2=1.253&f=h
fs/xfs/quota/xfs_qm_syscalls.c - 1.46 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/quota/xfs_qm_syscalls.c.diff?r1=text&tr1=1.46&r2=text&tr2=1.45&f=h
fs/xfs/linux-2.6/xfs_vnode.c - 1.161 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_vnode.c.diff?r1=text&tr1=1.161&r2=text&tr2=1.160&f=h
fs/xfs/linux-2.6/xfs_vnode.h - 1.158 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_vnode.h.diff?r1=text&tr1=1.158&r2=text&tr2=1.157&f=h
fs/xfs/linux-2.6/xfs_super.h - 1.80 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_super.h.diff?r1=text&tr1=1.80&r2=text&tr2=1.79&f=h
fs/xfs/linux-2.6/xfs_super.c - 1.442 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_super.c.diff?r1=text&tr1=1.442&r2=text&tr2=1.441&f=h
- kill bhv_vnode_t
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: TAKE 981498 - kill bhv_vnode_t
2008-07-28 6:26 TAKE 981498 - kill bhv_vnode_t Lachlan McIlroy
@ 2008-07-28 12:15 ` Christoph Hellwig
2008-07-29 1:32 ` Lachlan McIlroy
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2008-07-28 12:15 UTC (permalink / raw)
To: Lachlan McIlroy; +Cc: sgi.bugs.xfs, xfs
On Mon, Jul 28, 2008 at 04:26:25PM +1000, Lachlan McIlroy wrote:
> kill bhv_vnode_t
>
> All remaining bhv_vnode_t instance are in code that's more or less Linux
> specific. (Well, for xfs_acl.c that could be argued, but that code is
> on the removal list, too). So just do an s/bhv_vnode_t/struct inode/
> over the whole tree. We can clean up variable naming and some useless
> helpers later.
Thanks, but I wonder how this could even apply without the
intialize_vnode cleanup..
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: TAKE 981498 - kill bhv_vnode_t
2008-07-28 12:15 ` Christoph Hellwig
@ 2008-07-29 1:32 ` Lachlan McIlroy
0 siblings, 0 replies; 3+ messages in thread
From: Lachlan McIlroy @ 2008-07-29 1:32 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: sgi.bugs.xfs, xfs
Christoph Hellwig wrote:
> On Mon, Jul 28, 2008 at 04:26:25PM +1000, Lachlan McIlroy wrote:
>> kill bhv_vnode_t
>>
>> All remaining bhv_vnode_t instance are in code that's more or less Linux
>> specific. (Well, for xfs_acl.c that could be argued, but that code is
>> on the removal list, too). So just do an s/bhv_vnode_t/struct inode/
>> over the whole tree. We can clean up variable naming and some useless
>> helpers later.
>
> Thanks, but I wonder how this could even apply without the
> intialize_vnode cleanup..
It applied fine. Didn't build though - I had to change a couple more
bhv_vnode_t's.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-07-29 1:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-28 6:26 TAKE 981498 - kill bhv_vnode_t Lachlan McIlroy
2008-07-28 12:15 ` Christoph Hellwig
2008-07-29 1:32 ` Lachlan McIlroy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox