From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: with ECARTIS (v1.0.0; list xfs); Mon, 28 Jul 2008 20:54:28 -0700 (PDT) Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with SMTP id m6T3rsqp014979 for ; Mon, 28 Jul 2008 20:53:55 -0700 Message-ID: <488E9497.2090900@sgi.com> Date: Tue, 29 Jul 2008 13:55:03 +1000 From: Timothy Shimmin MIME-Version: 1.0 Subject: Re: [PATCH 02/15] use the same btree_cur union member for alloc and inobt trees References: <20080723200826.GC7401@lst.de> In-Reply-To: <20080723200826.GC7401@lst.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com List-Id: xfs To: Christoph Hellwig Cc: xfs@oss.sgi.com Hi there, This was fine but just one thing which looked odd: Christoph Hellwig wrote: > > Index: linux-2.6-xfs/fs/xfs/xfs_btree.c > =================================================================== > --- linux-2.6-xfs.orig/fs/xfs/xfs_btree.c 2008-07-16 03:24:18.000000000 +0200 > +++ linux-2.6-xfs/fs/xfs/xfs_btree.c 2008-07-16 03:24:19.000000000 +0200 > @@ -570,6 +570,13 @@ xfs_btree_init_cursor( > cur->bc_private.a.agbp = agbp; > cur->bc_private.a.agno = agno; > break; > + case XFS_BTNUM_INO: > + /* > + * Inode allocation btree fields. > + */ > + cur->bc_private.a.agbp = agbp; > + cur->bc_private.a.agno = agno; > + break; > case XFS_BTNUM_BMAP: > /* > * Bmap btree fields. > @@ -582,13 +589,6 @@ xfs_btree_init_cursor( > cur->bc_private.b.flags = 0; > cur->bc_private.b.whichfork = whichfork; > break; > - case XFS_BTNUM_INO: > - /* > - * Inode allocation btree fields. > - */ > - cur->bc_private.i.agbp = agbp; > - cur->bc_private.i.agno = agno; > - break; > default: Could probably just add XFS_BNUM_INO to the case below (and modify the comment): > case XFS_BTNUM_BNO: > case XFS_BTNUM_CNT: > /* > * Allocation btree fields. > */ > cur->bc_private.a.agbp = agbp; > cur->bc_private.a.agno = agno; > break; --Tim