From: Lachlan McIlroy <lachlan@sgi.com>
To: xfs@oss.sgi.com, xfs-dev <xfs-dev@sgi.com>
Subject: [PATCH] Don't release root inode until finished using it
Date: Tue, 05 Aug 2008 16:33:24 +1000 [thread overview]
Message-ID: <4897F434.2010309@sgi.com> (raw)
During unmount we're releasing the last reference on the root inode
before we've finished using it so move it after the XFS_SEND_UNMOUNT
hook.
--- a/fs/xfs/linux-2.6/xfs_super.c 2008-08-05 13:12:39.000000000 +1000
+++ b/fs/xfs/linux-2.6/xfs_super.c 2008-08-04 14:34:56.000000000 +1000
@@ -1132,8 +1132,6 @@ xfs_fs_put_super(
error = xfs_unmount_flush(mp, 0);
WARN_ON(error);
- IRELE(rip);
-
/*
* If we're forcing a shutdown, typically because of a media error,
* we want to make sure we invalidate dirty pages that belong to
@@ -1149,6 +1147,8 @@ xfs_fs_put_super(
unmount_event_flags);
}
+ IRELE(rip);
+
xfs_unmountfs(mp);
xfs_icsb_destroy_counters(mp);
xfs_close_devices(mp);
next reply other threads:[~2008-08-05 6:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 6:33 Lachlan McIlroy [this message]
2008-08-05 7:38 ` [PATCH] Don't release root inode until finished using it Dave Chinner
2008-08-06 0:01 ` Christoph Hellwig
2008-08-06 2:32 ` Lachlan McIlroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4897F434.2010309@sgi.com \
--to=lachlan@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox