From: Eric Sandeen <sandeen@sandeen.net>
To: Bhagi rathi <jahnu77@gmail.com>
Cc: Lachlan McIlroy <lachlan@sgi.com>,
sgi.bugs.xfs@engr.sgi.com, xfs@oss.sgi.com
Subject: Re: TAKE 981498 - use KM_MAYFAIL in xfs_mountfs
Date: Wed, 06 Aug 2008 14:55:28 -0500 [thread overview]
Message-ID: <489A01B0.5050606@sandeen.net> (raw)
In-Reply-To: <cc7060690808061022i1dce01dfx9e43ad3a75e5c936@mail.gmail.com>
Bhagi rathi wrote:
> Why are we going to block for ever? Mounting a file-system
> requires in-core log space buffers, reading of other buffers
> which needs allocation of memory greater than per ag
> structures.
>
> I am trying to understand why xfs_perag_t? Mount/Unmount
> are not frequent activities, it is better for them to succeed
> if operating system can allocate memory and take them
> forward.
But that's the big if, right?
If the system is so starved that you can't get this memory to even start
the mount process, I'm sure it's better to fail the mount with -ENOMEM
than to add to the current system memory stress.
In general KM_MAYFAIL sounds like a good plan when you can handle the
failure gracefully, I think.
-Eric
next prev parent reply other threads:[~2008-08-06 19:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 5:41 TAKE 981498 - use KM_MAYFAIL in xfs_mountfs Lachlan McIlroy
2008-08-06 17:22 ` Bhagi rathi
2008-08-06 19:55 ` Eric Sandeen [this message]
2008-08-06 20:22 ` Dave Chinner
2008-08-07 17:23 ` Bhagi rathi
2008-08-08 0:31 ` Dave Chinner
2008-08-08 5:22 ` Bhagi rathi
2008-08-07 17:18 ` Bhagi rathi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489A01B0.5050606@sandeen.net \
--to=sandeen@sandeen.net \
--cc=jahnu77@gmail.com \
--cc=lachlan@sgi.com \
--cc=sgi.bugs.xfs@engr.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox