From: Lachlan McIlroy <lachlan@sgi.com>
To: Lachlan McIlroy <lachlan@sgi.com>, xfs-dev <xfs-dev@sgi.com>,
xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] Tweak tracing allocation sizes
Date: Tue, 02 Sep 2008 16:12:14 +1000 [thread overview]
Message-ID: <48BCD93E.9040407@sgi.com> (raw)
In-Reply-To: <20080902055604.GD15962@disturbed>
Dave Chinner wrote:
> On Tue, Sep 02, 2008 at 03:48:46PM +1000, Lachlan McIlroy wrote:
>> The size of a single ktrace entry is 16 pointers so 128 bytes. For the case
>> of XFS_RW_KTRACE_SIZE which is 128 entries this equates to 16KB and on a system
>> with 4KB pages that is under memory pressure this can stall that process for a
>> significant time while it hunts for 4 free pages. Cutting this value back to
>> 32 means it will only need one page.
>
> That will effectively render that type of tracing useless - 32
> entries is not enough history to capture enough
> read/write/map/invalidate trace events to be meaningful. In the past
> I've often had to increase this to 256 or 512 entries to be able to
> capture the events necessary to debug problems...
A system that constantly locks up and/or stalls is useless too. Allocating
4 or more pages for every inode just taxes the system. Can you offer an
alternative - maybe a very large global trace buffer that is allocated at mount
time and shared by all inodes?
next prev parent reply other threads:[~2008-09-02 6:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-02 5:48 [PATCH] Tweak tracing allocation sizes Lachlan McIlroy
2008-09-02 5:56 ` Dave Chinner
2008-09-02 6:12 ` Lachlan McIlroy [this message]
2008-09-02 6:27 ` Dave Chinner
2008-09-02 21:54 ` Christoph Hellwig
2008-09-02 6:50 ` Andi Kleen
2008-09-02 21:55 ` Christoph Hellwig
2008-09-03 7:06 ` Andi Kleen
2008-09-03 12:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48BCD93E.9040407@sgi.com \
--to=lachlan@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox