From: Timothy Shimmin <tes@sgi.com>
To: lachlan@sgi.com
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] buffer flag NONE is actually DONE
Date: Tue, 02 Sep 2008 17:04:04 +1000 [thread overview]
Message-ID: <48BCE564.5070408@sgi.com> (raw)
In-Reply-To: <48BCC8C2.7040103@sgi.com>
Lachlan McIlroy wrote:
> Amazing but true.
>
> --- a/fs/xfs/xfsidbg.c 2008-09-02 14:52:11.000000000 +1000
> +++ b/fs/xfs/xfsidbg.c 2008-09-02 14:51:04.000000000 +1000
> @@ -1926,7 +1926,7 @@ static int kdbm_iptraceaddr(
>
> static char *bp_flag_vals[] = {
> /* 0 */ "READ", "WRITE", "MAPPED", "PARTIAL", "ASYNC",
> -/* 5 */ "NONE", "DELWRI", "STALE", "FS_MANAGED", "FS_DATAIOD",
> +/* 5 */ "DONE", "DELWRI", "STALE", "FS_MANAGED", "FS_DATAIOD",
> /* 10 */ "FORCEIO", "FLUSH", "READ_AHEAD", "DIRECTIO", "LOCK",
> /* 15 */ "TRYLOCK", "DONT_BLOCK", "PAGE_CACHE", "KMEM_ALLOC", "RUN_QUEUES",
> /* 20 */ "PRIVATE_BH", "DELWRI_Q",
Looks good.
Quick look at possible mismatching names:
11 "FLUSH" vs "ORDERED"
18 "KMEM_ALLOC" vs "PAGES"
22 NULL vs "PAGE_LOCKED"
--Tim
next prev parent reply other threads:[~2008-09-02 7:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-02 5:01 [PATCH] buffer flag NONE is actually DONE Lachlan McIlroy
2008-09-02 7:04 ` Timothy Shimmin [this message]
2008-09-03 4:04 ` Lachlan McIlroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48BCE564.5070408@sgi.com \
--to=tes@sgi.com \
--cc=lachlan@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox