* [PATCH] buffer flag NONE is actually DONE
@ 2008-09-02 5:01 Lachlan McIlroy
2008-09-02 7:04 ` Timothy Shimmin
0 siblings, 1 reply; 3+ messages in thread
From: Lachlan McIlroy @ 2008-09-02 5:01 UTC (permalink / raw)
To: xfs-dev, xfs-oss
Amazing but true.
--- a/fs/xfs/xfsidbg.c 2008-09-02 14:52:11.000000000 +1000
+++ b/fs/xfs/xfsidbg.c 2008-09-02 14:51:04.000000000 +1000
@@ -1926,7 +1926,7 @@ static int kdbm_iptraceaddr(
static char *bp_flag_vals[] = {
/* 0 */ "READ", "WRITE", "MAPPED", "PARTIAL", "ASYNC",
-/* 5 */ "NONE", "DELWRI", "STALE", "FS_MANAGED", "FS_DATAIOD",
+/* 5 */ "DONE", "DELWRI", "STALE", "FS_MANAGED", "FS_DATAIOD",
/* 10 */ "FORCEIO", "FLUSH", "READ_AHEAD", "DIRECTIO", "LOCK",
/* 15 */ "TRYLOCK", "DONT_BLOCK", "PAGE_CACHE", "KMEM_ALLOC", "RUN_QUEUES",
/* 20 */ "PRIVATE_BH", "DELWRI_Q",
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] buffer flag NONE is actually DONE
2008-09-02 5:01 [PATCH] buffer flag NONE is actually DONE Lachlan McIlroy
@ 2008-09-02 7:04 ` Timothy Shimmin
2008-09-03 4:04 ` Lachlan McIlroy
0 siblings, 1 reply; 3+ messages in thread
From: Timothy Shimmin @ 2008-09-02 7:04 UTC (permalink / raw)
To: lachlan; +Cc: xfs-dev, xfs-oss
Lachlan McIlroy wrote:
> Amazing but true.
>
> --- a/fs/xfs/xfsidbg.c 2008-09-02 14:52:11.000000000 +1000
> +++ b/fs/xfs/xfsidbg.c 2008-09-02 14:51:04.000000000 +1000
> @@ -1926,7 +1926,7 @@ static int kdbm_iptraceaddr(
>
> static char *bp_flag_vals[] = {
> /* 0 */ "READ", "WRITE", "MAPPED", "PARTIAL", "ASYNC",
> -/* 5 */ "NONE", "DELWRI", "STALE", "FS_MANAGED", "FS_DATAIOD",
> +/* 5 */ "DONE", "DELWRI", "STALE", "FS_MANAGED", "FS_DATAIOD",
> /* 10 */ "FORCEIO", "FLUSH", "READ_AHEAD", "DIRECTIO", "LOCK",
> /* 15 */ "TRYLOCK", "DONT_BLOCK", "PAGE_CACHE", "KMEM_ALLOC", "RUN_QUEUES",
> /* 20 */ "PRIVATE_BH", "DELWRI_Q",
Looks good.
Quick look at possible mismatching names:
11 "FLUSH" vs "ORDERED"
18 "KMEM_ALLOC" vs "PAGES"
22 NULL vs "PAGE_LOCKED"
--Tim
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] buffer flag NONE is actually DONE
2008-09-02 7:04 ` Timothy Shimmin
@ 2008-09-03 4:04 ` Lachlan McIlroy
0 siblings, 0 replies; 3+ messages in thread
From: Lachlan McIlroy @ 2008-09-03 4:04 UTC (permalink / raw)
To: Timothy Shimmin; +Cc: xfs-dev, xfs-oss
How's this then? There's a few flags that don't exist anymore.
--- a/fs/xfs/xfsidbg.c 2008-09-03 13:53:12.000000000 +1000
+++ b/fs/xfs/xfsidbg.c 2008-09-03 13:59:47.000000000 +1000
@@ -1925,11 +1925,11 @@ static int kdbm_iptraceaddr(
static char *bp_flag_vals[] = {
-/* 0 */ "READ", "WRITE", "MAPPED", "PARTIAL", "ASYNC",
-/* 5 */ "NONE", "DELWRI", "STALE", "FS_MANAGED", "FS_DATAIOD",
-/* 10 */ "FORCEIO", "FLUSH", "READ_AHEAD", "DIRECTIO", "LOCK",
-/* 15 */ "TRYLOCK", "DONT_BLOCK", "PAGE_CACHE", "KMEM_ALLOC", "RUN_QUEUES",
-/* 20 */ "PRIVATE_BH", "DELWRI_Q",
+/* 0 */ "READ", "WRITE", "MAPPED", "<unknown(3)>", "ASYNC",
+/* 5 */ "DONE", "DELWRI", "STALE", "FS_MANAGED", "<unknown(9)>",
+/* 10 */ "<unknown(10)>", "ORDERED", "READ_AHEAD", "<unknown(13)>", "LOCK",
+/* 15 */ "TRYLOCK", "DONT_BLOCK", "PAGE_CACHE", "PAGES", "RUN_QUEUES",
+/* 20 */ "<unknown(20)>", "DELWRI_Q", "PAGE_LOCKED",
NULL };
static char *iomap_flag_vals[] = {
Timothy Shimmin wrote:
> Lachlan McIlroy wrote:
>> Amazing but true.
>>
>> --- a/fs/xfs/xfsidbg.c 2008-09-02 14:52:11.000000000 +1000
>> +++ b/fs/xfs/xfsidbg.c 2008-09-02 14:51:04.000000000 +1000
>> @@ -1926,7 +1926,7 @@ static int kdbm_iptraceaddr(
>>
>> static char *bp_flag_vals[] = {
>> /* 0 */ "READ", "WRITE", "MAPPED", "PARTIAL", "ASYNC",
>> -/* 5 */ "NONE", "DELWRI", "STALE", "FS_MANAGED", "FS_DATAIOD",
>> +/* 5 */ "DONE", "DELWRI", "STALE", "FS_MANAGED", "FS_DATAIOD",
>> /* 10 */ "FORCEIO", "FLUSH", "READ_AHEAD", "DIRECTIO", "LOCK",
>> /* 15 */ "TRYLOCK", "DONT_BLOCK", "PAGE_CACHE", "KMEM_ALLOC", "RUN_QUEUES",
>> /* 20 */ "PRIVATE_BH", "DELWRI_Q",
>
> Looks good.
>
> Quick look at possible mismatching names:
>
> 11 "FLUSH" vs "ORDERED"
> 18 "KMEM_ALLOC" vs "PAGES"
> 22 NULL vs "PAGE_LOCKED"
>
> --Tim
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-09-03 3:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-02 5:01 [PATCH] buffer flag NONE is actually DONE Lachlan McIlroy
2008-09-02 7:04 ` Timothy Shimmin
2008-09-03 4:04 ` Lachlan McIlroy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox