From: Timothy Shimmin <tes@sgi.com>
To: lachlan@sgi.com
Cc: xfs-oss <xfs@oss.sgi.com>, xfs-dev <xfs-dev@sgi.com>
Subject: Re: [PATCH V2] Fix buffer flag definitions for xbp idbg command
Date: Fri, 19 Sep 2008 13:40:15 +1000 [thread overview]
Message-ID: <48D31F1F.6040009@sgi.com> (raw)
In-Reply-To: <48D312BF.5000208@sgi.com>
Lachlan McIlroy wrote:
> PARTIAL no longer exists
> NONE is actually DONE
> FS_DATAIOD no longer exists
> FORCEIO no longer exists
> FLUSH is actually ORDERED
> DIRECTIO no longer exists
> KMEM_ALLOC is actually PAGES
> PRIVATE_BH no longer exists
> PAGE_LOCKED is a new flag
>
> --- a/fs/xfs/xfsidbg.c 2008-09-19 12:29:57.000000000 +1000
> +++ b/fs/xfs/xfsidbg.c 2008-09-16 12:34:12.000000000 +1000
> @@ -1925,11 +1925,11 @@ static int kdbm_iptraceaddr(
>
>
> static char *bp_flag_vals[] = {
> -/* 0 */ "READ", "WRITE", "MAPPED", "PARTIAL", "ASYNC",
> -/* 5 */ "NONE", "DELWRI", "STALE", "FS_MANAGED", "FS_DATAIOD",
> -/* 10 */ "FORCEIO", "FLUSH", "READ_AHEAD", "DIRECTIO", "LOCK",
> -/* 15 */ "TRYLOCK", "DONT_BLOCK", "PAGE_CACHE", "KMEM_ALLOC",
> "RUN_QUEUES",
> -/* 20 */ "PRIVATE_BH", "DELWRI_Q",
> +/* 0 */ "READ", "WRITE", "MAPPED", "<unknown(3)>", "ASYNC",
> +/* 5 */ "DONE", "DELWRI", "STALE", "FS_MANAGED", "<unknown(9)>",
> +/* 10 */ "<unknown(10)>", "ORDERED", "READ_AHEAD", "<unknown(13)>",
> "LOCK",
> +/* 15 */ "TRYLOCK", "DONT_BLOCK", "PAGE_CACHE", "PAGES", "RUN_QUEUES",
> +/* 20 */ "<unknown(20)>", "DELWRI_Q", "PAGE_LOCKED",
> NULL };
>
> static char *iomap_flag_vals[] = {
Looks good. Thanks.
--Tim
prev parent reply other threads:[~2008-09-19 3:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-19 2:47 [PATCH V2] Fix buffer flag definitions for xbp idbg command Lachlan McIlroy
2008-09-19 3:40 ` Timothy Shimmin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D31F1F.6040009@sgi.com \
--to=tes@sgi.com \
--cc=lachlan@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox