public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH V2] Fix buffer flag definitions for xbp idbg command
@ 2008-09-19  2:47 Lachlan McIlroy
  2008-09-19  3:40 ` Timothy Shimmin
  0 siblings, 1 reply; 2+ messages in thread
From: Lachlan McIlroy @ 2008-09-19  2:47 UTC (permalink / raw)
  To: xfs-oss, xfs-dev

PARTIAL no longer exists
NONE is actually DONE
FS_DATAIOD no longer exists
FORCEIO no longer exists
FLUSH is actually ORDERED
DIRECTIO no longer exists
KMEM_ALLOC is actually PAGES
PRIVATE_BH no longer exists
PAGE_LOCKED is a new flag

--- a/fs/xfs/xfsidbg.c	2008-09-19 12:29:57.000000000 +1000
+++ b/fs/xfs/xfsidbg.c	2008-09-16 12:34:12.000000000 +1000
@@ -1925,11 +1925,11 @@ static int	kdbm_iptraceaddr(
 
 
 static char	*bp_flag_vals[] = {
-/*  0 */ "READ", "WRITE", "MAPPED", "PARTIAL", "ASYNC",
-/*  5 */ "NONE", "DELWRI",  "STALE", "FS_MANAGED", "FS_DATAIOD",
-/* 10 */ "FORCEIO", "FLUSH", "READ_AHEAD", "DIRECTIO", "LOCK",
-/* 15 */ "TRYLOCK", "DONT_BLOCK", "PAGE_CACHE", "KMEM_ALLOC", "RUN_QUEUES",
-/* 20 */ "PRIVATE_BH", "DELWRI_Q",
+/*  0 */ "READ", "WRITE", "MAPPED", "<unknown(3)>", "ASYNC",
+/*  5 */ "DONE", "DELWRI",  "STALE", "FS_MANAGED", "<unknown(9)>",
+/* 10 */ "<unknown(10)>", "ORDERED", "READ_AHEAD", "<unknown(13)>", "LOCK",
+/* 15 */ "TRYLOCK", "DONT_BLOCK", "PAGE_CACHE", "PAGES", "RUN_QUEUES",
+/* 20 */ "<unknown(20)>", "DELWRI_Q", "PAGE_LOCKED",
 	 NULL };
 
 static char	*iomap_flag_vals[] = {

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH V2] Fix buffer flag definitions for xbp idbg command
  2008-09-19  2:47 [PATCH V2] Fix buffer flag definitions for xbp idbg command Lachlan McIlroy
@ 2008-09-19  3:40 ` Timothy Shimmin
  0 siblings, 0 replies; 2+ messages in thread
From: Timothy Shimmin @ 2008-09-19  3:40 UTC (permalink / raw)
  To: lachlan; +Cc: xfs-oss, xfs-dev

Lachlan McIlroy wrote:
> PARTIAL no longer exists
> NONE is actually DONE
> FS_DATAIOD no longer exists
> FORCEIO no longer exists
> FLUSH is actually ORDERED
> DIRECTIO no longer exists
> KMEM_ALLOC is actually PAGES
> PRIVATE_BH no longer exists
> PAGE_LOCKED is a new flag
> 
> --- a/fs/xfs/xfsidbg.c    2008-09-19 12:29:57.000000000 +1000
> +++ b/fs/xfs/xfsidbg.c    2008-09-16 12:34:12.000000000 +1000
> @@ -1925,11 +1925,11 @@ static int    kdbm_iptraceaddr(
> 
> 
> static char    *bp_flag_vals[] = {
> -/*  0 */ "READ", "WRITE", "MAPPED", "PARTIAL", "ASYNC",
> -/*  5 */ "NONE", "DELWRI",  "STALE", "FS_MANAGED", "FS_DATAIOD",
> -/* 10 */ "FORCEIO", "FLUSH", "READ_AHEAD", "DIRECTIO", "LOCK",
> -/* 15 */ "TRYLOCK", "DONT_BLOCK", "PAGE_CACHE", "KMEM_ALLOC",
> "RUN_QUEUES",
> -/* 20 */ "PRIVATE_BH", "DELWRI_Q",
> +/*  0 */ "READ", "WRITE", "MAPPED", "<unknown(3)>", "ASYNC",
> +/*  5 */ "DONE", "DELWRI",  "STALE", "FS_MANAGED", "<unknown(9)>",
> +/* 10 */ "<unknown(10)>", "ORDERED", "READ_AHEAD", "<unknown(13)>",
> "LOCK",
> +/* 15 */ "TRYLOCK", "DONT_BLOCK", "PAGE_CACHE", "PAGES", "RUN_QUEUES",
> +/* 20 */ "<unknown(20)>", "DELWRI_Q", "PAGE_LOCKED",
>      NULL };
> 
> static char    *iomap_flag_vals[] = {

Looks good. Thanks.

--Tim

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-09-19  3:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-19  2:47 [PATCH V2] Fix buffer flag definitions for xbp idbg command Lachlan McIlroy
2008-09-19  3:40 ` Timothy Shimmin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox