From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xfs-bounce@oss.sgi.com>
Received: with ECARTIS (v1.0.0; list xfs); Thu, 18 Sep 2008 20:38:47 -0700 (PDT)
Received: from relay.sgi.com (netops-testserver-3.corp.sgi.com [192.26.57.72])
	by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id m8J3cjZ5017261
	for <xfs@oss.sgi.com>; Thu, 18 Sep 2008 20:38:45 -0700
Message-ID: <48D31F1F.6040009@sgi.com>
Date: Fri, 19 Sep 2008 13:40:15 +1000
From: Timothy Shimmin <tes@sgi.com>
MIME-Version: 1.0
Subject: Re: [PATCH V2] Fix buffer flag definitions for xbp idbg command
References: <48D312BF.5000208@sgi.com>
In-Reply-To: <48D312BF.5000208@sgi.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: xfs-bounce@oss.sgi.com
Errors-to: xfs-bounce@oss.sgi.com
List-Id: xfs
To: lachlan@sgi.com
Cc: xfs-oss <xfs@oss.sgi.com>, xfs-dev <xfs-dev@sgi.com>

Lachlan McIlroy wrote:
> PARTIAL no longer exists
> NONE is actually DONE
> FS_DATAIOD no longer exists
> FORCEIO no longer exists
> FLUSH is actually ORDERED
> DIRECTIO no longer exists
> KMEM_ALLOC is actually PAGES
> PRIVATE_BH no longer exists
> PAGE_LOCKED is a new flag
> 
> --- a/fs/xfs/xfsidbg.c    2008-09-19 12:29:57.000000000 +1000
> +++ b/fs/xfs/xfsidbg.c    2008-09-16 12:34:12.000000000 +1000
> @@ -1925,11 +1925,11 @@ static int    kdbm_iptraceaddr(
> 
> 
> static char    *bp_flag_vals[] = {
> -/*  0 */ "READ", "WRITE", "MAPPED", "PARTIAL", "ASYNC",
> -/*  5 */ "NONE", "DELWRI",  "STALE", "FS_MANAGED", "FS_DATAIOD",
> -/* 10 */ "FORCEIO", "FLUSH", "READ_AHEAD", "DIRECTIO", "LOCK",
> -/* 15 */ "TRYLOCK", "DONT_BLOCK", "PAGE_CACHE", "KMEM_ALLOC",
> "RUN_QUEUES",
> -/* 20 */ "PRIVATE_BH", "DELWRI_Q",
> +/*  0 */ "READ", "WRITE", "MAPPED", "<unknown(3)>", "ASYNC",
> +/*  5 */ "DONE", "DELWRI",  "STALE", "FS_MANAGED", "<unknown(9)>",
> +/* 10 */ "<unknown(10)>", "ORDERED", "READ_AHEAD", "<unknown(13)>",
> "LOCK",
> +/* 15 */ "TRYLOCK", "DONT_BLOCK", "PAGE_CACHE", "PAGES", "RUN_QUEUES",
> +/* 20 */ "<unknown(20)>", "DELWRI_Q", "PAGE_LOCKED",
>      NULL };
> 
> static char    *iomap_flag_vals[] = {

Looks good. Thanks.

--Tim