From: Timothy Shimmin <tes@sgi.com>
To: lachlan@sgi.com
Cc: xfs-oss <xfs@oss.sgi.com>, xfs-dev <xfs-dev@sgi.com>
Subject: Re: [PATCH] xail idbg command doesn't increment count in each loop
Date: Fri, 19 Sep 2008 14:19:43 +1000 [thread overview]
Message-ID: <48D3285F.2010600@sgi.com> (raw)
In-Reply-To: <48D31095.908@sgi.com>
Lachlan McIlroy wrote:
> count is never incremented on each log item because it is unreachable code.
>
> --- a/fs/xfs/xfsidbg.c 2008-09-19 12:27:05.000000000 +1000
> +++ b/fs/xfs/xfsidbg.c 2008-09-16 12:34:12.000000000 +1000
> @@ -6249,8 +6249,8 @@ xfsidbg_xaildump(xfs_mount_t *mp)
> default:
> kdb_printf("Unknown item type %d\n", lip->li_type);
> break;
> - count++;
> }
> + count++;
> }
> }
Oops - count++ after break.
Looks good.
--Tim
prev parent reply other threads:[~2008-09-19 4:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-19 2:38 [PATCH] xail idbg command doesn't increment count in each loop Lachlan McIlroy
2008-09-19 4:19 ` Timothy Shimmin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D3285F.2010600@sgi.com \
--to=tes@sgi.com \
--cc=lachlan@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox