Re: [PATCH v2] Use atomic_t and wait_event to track dquot pincount

[Mark Goodwin <markgw@sgi.com>]

Peter Leckie wrote:
> Lachlan McIlroy wrote:
>> The underlying problem has nothing to do with xfs_qm_dqflush() - the
>> spurious wakeups are caused by calls to wake_up_process() that 
>> arbitrarily
>> wake up a process that is in a state where it shouldn't be woken up.  If
>> we don't fix the spurious wakeups then we could easily re-introduce this
>> problem again.  If xfs_qm_dqflush() should be non-blocking then that's a
>> separate change and it sounds like a good change too.
> Ok so what do we want to do. It almost sounds like there are 3 issues I 
> need to solve,
> first clean up the code, second make xfs_qm_dqflush() non blocking, and 3ed
> fix up the spurious wakeups.
> 
> Should I propose 3 patches to fix each of these issues?

yes - can we take the quota fix "as-is" for now. Those of us shipping
NAS servers with quotas enabled need this fix.

The other two issues need more investigation and look like they may have
more fundamental implications - they should be separate bugs.

Thanks

-- 

  Mark Goodwin                                  markgw@sgi.com
  Engineering Manager for XFS and PCP    Phone: +61-3-99631937
  SGI Australian Software Group           Cell: +61-4-18969583
-------------------------------------------------------------