From: Eric Sandeen <sandeen@sandeen.net>
To: Barry Naujok <bnaujok@sgi.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [REVIEW] Show pointer address for mem dump with corruption error
Date: Thu, 25 Sep 2008 23:06:05 -0500 [thread overview]
Message-ID: <48DC5FAD.2070409@sandeen.net> (raw)
In-Reply-To: <op.uh2jplxz3jf8g2@pc-bnaujok.melbourne.sgi.com>
Barry Naujok wrote:
> When XFS detects corruption, it prints a message and a small hex dump
> of the offending code.
>
> The first value in this hexdump currently is "0000000:" which is just
> the offset into the pointer being passed to print_hex_dump().
>
> The following patch changes this to display the address of the memory
> dump:
>
> --- a/fs/xfs/support/debug.c 2008-09-26 13:15:02.000000000 +1000
> +++ b/fs/xfs/support/debug.c 2008-09-26 12:53:50.765134441 +1000
> @@ -84,5 +84,5 @@ assfail(char *expr, char *file, int line
> void
> xfs_hex_dump(void *p, int length)
> {
> - print_hex_dump(KERN_ALERT, "", DUMP_PREFIX_OFFSET, 16, 1, p,
> length, 1);
> + print_hex_dump(KERN_ALERT, "", DUMP_PREFIX_ADDRESS, 16, 1, p,
> length, 1);
> }
>
>
Looks fine (and a fine idea) to me :)
-Eric
prev parent reply other threads:[~2008-09-26 4:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-26 3:23 [REVIEW] Show pointer address for mem dump with corruption error Barry Naujok
2008-09-26 4:06 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48DC5FAD.2070409@sandeen.net \
--to=sandeen@sandeen.net \
--cc=bnaujok@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox