* [REVIEW] Show pointer address for mem dump with corruption error
@ 2008-09-26 3:23 Barry Naujok
2008-09-26 4:06 ` Eric Sandeen
0 siblings, 1 reply; 2+ messages in thread
From: Barry Naujok @ 2008-09-26 3:23 UTC (permalink / raw)
To: xfs@oss.sgi.com
When XFS detects corruption, it prints a message and a small hex dump
of the offending code.
The first value in this hexdump currently is "0000000:" which is just
the offset into the pointer being passed to print_hex_dump().
The following patch changes this to display the address of the memory
dump:
--- a/fs/xfs/support/debug.c 2008-09-26 13:15:02.000000000 +1000
+++ b/fs/xfs/support/debug.c 2008-09-26 12:53:50.765134441 +1000
@@ -84,5 +84,5 @@ assfail(char *expr, char *file, int line
void
xfs_hex_dump(void *p, int length)
{
- print_hex_dump(KERN_ALERT, "", DUMP_PREFIX_OFFSET, 16, 1, p,
length, 1);
+ print_hex_dump(KERN_ALERT, "", DUMP_PREFIX_ADDRESS, 16, 1, p,
length, 1);
}
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [REVIEW] Show pointer address for mem dump with corruption error
2008-09-26 3:23 [REVIEW] Show pointer address for mem dump with corruption error Barry Naujok
@ 2008-09-26 4:06 ` Eric Sandeen
0 siblings, 0 replies; 2+ messages in thread
From: Eric Sandeen @ 2008-09-26 4:06 UTC (permalink / raw)
To: Barry Naujok; +Cc: xfs@oss.sgi.com
Barry Naujok wrote:
> When XFS detects corruption, it prints a message and a small hex dump
> of the offending code.
>
> The first value in this hexdump currently is "0000000:" which is just
> the offset into the pointer being passed to print_hex_dump().
>
> The following patch changes this to display the address of the memory
> dump:
>
> --- a/fs/xfs/support/debug.c 2008-09-26 13:15:02.000000000 +1000
> +++ b/fs/xfs/support/debug.c 2008-09-26 12:53:50.765134441 +1000
> @@ -84,5 +84,5 @@ assfail(char *expr, char *file, int line
> void
> xfs_hex_dump(void *p, int length)
> {
> - print_hex_dump(KERN_ALERT, "", DUMP_PREFIX_OFFSET, 16, 1, p,
> length, 1);
> + print_hex_dump(KERN_ALERT, "", DUMP_PREFIX_ADDRESS, 16, 1, p,
> length, 1);
> }
>
>
Looks fine (and a fine idea) to me :)
-Eric
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-26 4:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-26 3:23 [REVIEW] Show pointer address for mem dump with corruption error Barry Naujok
2008-09-26 4:06 ` Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox