public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Donald Douwsma <donaldd@sgi.com>
To: Peter Leckie <pleckie@sgi.com>
Cc: xfs@oss.sgi.com, xfs-dev <xfs-dev@sgi.com>
Subject: Re: [PATCH] Clean up dquot pincount code
Date: Fri, 26 Sep 2008 14:30:45 +1000	[thread overview]
Message-ID: <48DC6575.3060403@sgi.com> (raw)
In-Reply-To: <48DC6102.2040602@sgi.com>

Peter Leckie wrote:
> This is a code cleanup and optimization that removes a per mount point
> spinlock from the quota code and cleans up the code.
> 
> The patch changes the pincount from being an int protected by a spinlock
> to an atomic_t allowing the pincount to be manipulated without holding
> the spinlock.
> 
> This cleanup also protects against random wakup's of both the aild and
> xfssyncd by reevaluating the pincount after been woken. Two latter patches
> will address the Spurious wakeups.
> 
> Signed-off-by: Peter Leckie <pleckie@sgi.com>

Looks good Peter, nice to get rid of that spinlock.

Don

  reply	other threads:[~2008-09-26  4:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-26  4:11 [PATCH] Clean up dquot pincount code Peter Leckie
2008-09-26  4:30 ` Donald Douwsma [this message]
2008-09-26  4:33 ` Dave Chinner
2008-09-26  6:31 ` Christoph Hellwig
2008-09-29  1:24 ` Peter Leckie
2008-09-29  2:11   ` Donald Douwsma
  -- strict thread matches above, loose matches on Subject: below --
2008-09-30  2:17 (no subject) Peter Leckie
2008-09-30  2:22 ` [PATCH] Clean up dquot pincount code Peter Leckie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48DC6575.3060403@sgi.com \
    --to=donaldd@sgi.com \
    --cc=pleckie@sgi.com \
    --cc=xfs-dev@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox