* Re: compiler warning after applying btree patches
2008-09-29 7:33 compiler warning after applying btree patches Lachlan McIlroy
@ 2008-09-29 7:30 ` Christoph Hellwig
2008-09-29 8:41 ` Lachlan McIlroy
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2008-09-29 7:30 UTC (permalink / raw)
To: Lachlan McIlroy; +Cc: Christoph Hellwig, xfs-oss
On Mon, Sep 29, 2008 at 05:33:41PM +1000, Lachlan McIlroy wrote:
> Christoph,
>
> After applying the first round of btree patches we've now got this warning
> when building a non-debug xfs module.
>
> CC fs/xfs/xfs_btree.o
> fs/xfs/xfs_btree.c:191: warning: ?xfs_btree_check_ptr? defined but not used
>
> I took a quick look through your next round of btree patches but couldn't
> see a fix for it. Did I miss something in the original patch set? Is it
> fixed in a later patch? If not here's a fix:
No, it's not used for now. For some reason I missed the warning.
The patch looks good, can you also put it into xfs-cmds so the two
copies stay in sync?
^ permalink raw reply [flat|nested] 3+ messages in thread
* compiler warning after applying btree patches
@ 2008-09-29 7:33 Lachlan McIlroy
2008-09-29 7:30 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Lachlan McIlroy @ 2008-09-29 7:33 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs-oss
Christoph,
After applying the first round of btree patches we've now got this warning
when building a non-debug xfs module.
CC fs/xfs/xfs_btree.o
fs/xfs/xfs_btree.c:191: warning: ‘xfs_btree_check_ptr’ defined but not used
I took a quick look through your next round of btree patches but couldn't
see a fix for it. Did I miss something in the original patch set? Is it
fixed in a later patch? If not here's a fix:
--- a/fs/xfs/xfs_btree.c 2008-09-29 17:19:24.000000000 +1000
+++ b/fs/xfs/xfs_btree.c 2008-09-29 17:22:33.000000000 +1000
@@ -160,6 +160,7 @@ xfs_btree_check_lptr(
return 0;
}
+#ifdef DEBUG
/*
* Check that (short) pointer is ok.
*/
@@ -197,6 +198,7 @@ xfs_btree_check_ptr(
be32_to_cpu((&ptr->s)[index]), level);
}
}
+#endif
/*
* Delete the btree cursor.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: compiler warning after applying btree patches
2008-09-29 7:30 ` Christoph Hellwig
@ 2008-09-29 8:41 ` Lachlan McIlroy
0 siblings, 0 replies; 3+ messages in thread
From: Lachlan McIlroy @ 2008-09-29 8:41 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs-oss
Christoph Hellwig wrote:
> On Mon, Sep 29, 2008 at 05:33:41PM +1000, Lachlan McIlroy wrote:
>> Christoph,
>>
>> After applying the first round of btree patches we've now got this warning
>> when building a non-debug xfs module.
>>
>> CC fs/xfs/xfs_btree.o
>> fs/xfs/xfs_btree.c:191: warning: ?xfs_btree_check_ptr? defined but not used
>>
>> I took a quick look through your next round of btree patches but couldn't
>> see a fix for it. Did I miss something in the original patch set? Is it
>> fixed in a later patch? If not here's a fix:
>
> No, it's not used for now. For some reason I missed the warning.
>
> The patch looks good, can you also put it into xfs-cmds so the two
> copies stay in sync?
Okay. Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-09-29 8:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-29 7:33 compiler warning after applying btree patches Lachlan McIlroy
2008-09-29 7:30 ` Christoph Hellwig
2008-09-29 8:41 ` Lachlan McIlroy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox