public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* PARTIAL TAKE 987159 - Fix extent list corruption in xfs_iext_irec_compact_full().
@ 2008-09-23  3:28 Lachlan McIlroy
  2008-10-05 11:56 ` Eric Sandeen
  0 siblings, 1 reply; 5+ messages in thread
From: Lachlan McIlroy @ 2008-09-23  3:28 UTC (permalink / raw)
  To: sgi.bugs.xfs, xfs

Fix extent list corruption in xfs_iext_irec_compact_full().

If we don't move all the records from the next buffer into the current buffer
then we need to update the er_extoff field of the next buffer as we shift the
remaining records to the start of the buffer.

Date:  Tue Sep 23 13:20:30 AEST 2008
Workarea:  redback.melbourne.sgi.com:/home/lachlan/isms/2.6.x-xfs
Inspected by:  
sandeen@sandeen.net
cattelan@thebarn.com
Author:  lachlan

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:32165a
fs/xfs/xfs_inode.c - 1.521 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_inode.c.diff?r1=text&tr1=1.521&r2=text&tr2=1.520&f=h
	- Fix extent list corruption in xfs_iext_irec_compact_full().

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: PARTIAL TAKE 987159 - Fix extent list corruption in xfs_iext_irec_compact_full().
  2008-09-23  3:28 PARTIAL TAKE 987159 - Fix extent list corruption in xfs_iext_irec_compact_full() Lachlan McIlroy
@ 2008-10-05 11:56 ` Eric Sandeen
  2008-10-05 12:00   ` Eric Sandeen
  0 siblings, 1 reply; 5+ messages in thread
From: Eric Sandeen @ 2008-10-05 11:56 UTC (permalink / raw)
  To: Lachlan McIlroy; +Cc: xfs

Lachlan McIlroy wrote:
> Fix extent list corruption in xfs_iext_irec_compact_full().
> 
> If we don't move all the records from the next buffer into the current buffer
> then we need to update the er_extoff field of the next buffer as we shift the
> remaining records to the start of the buffer.
> 
> Date:  Tue Sep 23 13:20:30 AEST 2008
> Workarea:  redback.melbourne.sgi.com:/home/lachlan/isms/2.6.x-xfs
> Inspected by:  
> sandeen@sandeen.net
> cattelan@thebarn.com
> Author:  lachlan
> 
> The following file(s) were checked into:
>   longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb
> 
> 
> Modid:  xfs-linux-melb:xfs-kern:32165a
> fs/xfs/xfs_inode.c - 1.521 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/> xfs_inode.c.diff?r1=text&tr1=1.521&r2=text&tr2=1.520&f=h
> http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_inode.c.diff?r1=text&tr1=1.521&r2=text&tr2=1.520&f=h
> 	- Fix extent list corruption in xfs_iext_irec_compact_full().

Are there plans to try to get this, and possibly the compact_full
removal pushed into 2.6.27 still?  (and maybe even 2.6.26.x?)

-Eric

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: PARTIAL TAKE 987159 - Fix extent list corruption in xfs_iext_irec_compact_full().
  2008-10-05 11:56 ` Eric Sandeen
@ 2008-10-05 12:00   ` Eric Sandeen
  2008-10-06  1:00     ` Mark Goodwin
  0 siblings, 1 reply; 5+ messages in thread
From: Eric Sandeen @ 2008-10-05 12:00 UTC (permalink / raw)
  To: Lachlan McIlroy; +Cc: xfs

Eric Sandeen wrote:
> Lachlan McIlroy wrote:


>> 	- Fix extent list corruption in xfs_iext_irec_compact_full().
> 
> Are there plans to try to get this, and possibly the compact_full
> removal pushed into 2.6.27 still?  (and maybe even 2.6.26.x?)
> 
> -Eric
> 
> 

ugh already in, sorry.  ignore me!

-Eric

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: PARTIAL TAKE 987159 - Fix extent list corruption in xfs_iext_irec_compact_full().
  2008-10-05 12:00   ` Eric Sandeen
@ 2008-10-06  1:00     ` Mark Goodwin
  2008-10-06 17:24       ` Russell Cattelan
  0 siblings, 1 reply; 5+ messages in thread
From: Mark Goodwin @ 2008-10-06  1:00 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: Lachlan McIlroy, xfs



Eric Sandeen wrote:
> Eric Sandeen wrote:
>> Lachlan McIlroy wrote:
> 
> 
>>> 	- Fix extent list corruption in xfs_iext_irec_compact_full().
>> Are there plans to try to get this, and possibly the compact_full
>> removal pushed into 2.6.27 still?  (and maybe even 2.6.26.x?)
>>
>> -Eric
>>
>>
> 
> ugh already in, sorry.  ignore me!

yes, already in .27, but not yet .26 as far as I know.

Cheers

-- 

  Mark Goodwin                                  markgw@sgi.com
  Engineering Manager for XFS and PCP    Phone: +61-3-99631937
  SGI Australian Software Group           Cell: +61-4-18969583
-------------------------------------------------------------

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: PARTIAL TAKE 987159 - Fix extent list corruption in xfs_iext_irec_compact_full().
  2008-10-06  1:00     ` Mark Goodwin
@ 2008-10-06 17:24       ` Russell Cattelan
  0 siblings, 0 replies; 5+ messages in thread
From: Russell Cattelan @ 2008-10-06 17:24 UTC (permalink / raw)
  To: markgw; +Cc: Eric Sandeen, Lachlan McIlroy, xfs

Mark Goodwin wrote:
>
>
> Eric Sandeen wrote:
>> Eric Sandeen wrote:
>>> Lachlan McIlroy wrote:
>>
>>
>>>>     - Fix extent list corruption in xfs_iext_irec_compact_full().
>>> Are there plans to try to get this, and possibly the compact_full
>>> removal pushed into 2.6.27 still?  (and maybe even 2.6.26.x?)
>>>
>>> -Eric
>>>
>>>
>>
>> ugh already in, sorry.  ignore me!
>
> yes, already in .27, but not yet .26 as far as I know.
>
> Cheers
>
BTW can we get xfsidbg fixed up so it compiles.
Also it would be nice to add the extra debug patch into the extent list 
print function.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-10-06 17:22 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-23  3:28 PARTIAL TAKE 987159 - Fix extent list corruption in xfs_iext_irec_compact_full() Lachlan McIlroy
2008-10-05 11:56 ` Eric Sandeen
2008-10-05 12:00   ` Eric Sandeen
2008-10-06  1:00     ` Mark Goodwin
2008-10-06 17:24       ` Russell Cattelan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox